To recreate: -Create some HTML Customizations and some News item that are set to display on the OPAC. -Go to the OPAC and notice none of these display. Possibly from Bug 15326?
I see that this only happens when I do not set a "Publication date:". That makes sense for News, but HTML customizations should not required a Publication date or an Expiration date
Created attachment 139824 [details] [review] Bug 31450 - HTML customizations and News will not display on OPAC without Publication date To test: 1) Create some HTML Customizations and some News items that are set to display on the OPAC. Create one of each: [ 'With publication date today', 'With publication date in the future', 'Without publication date' ] 2) Note that news with publication date 'today' will display; with publication date 'in the future' will not display; with publication date unset will not display. 3) Note that html_customizations with date 'today' will display; with publication date 'in the future' will not display; with publication date unset will display. 4) Sign-Off
Created attachment 139825 [details] [review] Bug 31450 - HTML customizations and News will not display on OPAC without Publication date To test: 1) Create some HTML Customizations and some News items that are set to display on the OPAC. Create one of each: [ 'With publication date today', 'With publication date in the future', 'Without publication date' ] 2) Note that news with publication date 'today' will display; with publication date 'in the future' will not display; with publication date unset will not display. 3) Note that html_customizations with date 'today' will display; with publication date 'in the future' will not display; with publication date unset will display. 4) Sign-Off
Hi Paul, could you please check the patch? It only seems to be removing some debug lines.
I think the obsoleted patch wasn't supposed to be?
*** Bug 32987 has been marked as a duplicate of this bug. ***
If the commit line is exactly the same, one patch will overwrite the other. I'll fix it.
Created attachment 146914 [details] [review] Bug 31450: HTML customizations and News will not display on OPAC without Publication date To test: 1) Create some HTML Customizations and some News items that are set to display on the OPAC. Create one of each: [ 'With publication date today', 'With publication date in the future', 'Without publication date' ] 2) Note that news with publication date 'today' will display; with publication date 'in the future' will not display; with publication date unset will not display. 3) Note that html_customizations with date 'today' will display; with publication date 'in the future' will not display; with publication date unset will display. 4) Sign-Off
Created attachment 146915 [details] [review] Bug 31450: Remove some debug lines
Created attachment 146925 [details] [review] Bug 31450: HTML customizations and News will not display on OPAC without Publication date To test: 1) Create some HTML Customizations and some News items that are set to display on the OPAC. Create one of each: [ 'With publication date today', 'With publication date in the future', 'Without publication date' ] 2) Note that news with publication date 'today' will display; with publication date 'in the future' will not display; with publication date unset will not display. 3) Note that html_customizations with date 'today' will display; with publication date 'in the future' will not display; with publication date unset will display. 4) Sign-Off Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 146926 [details] [review] Bug 31450: Remove some debug lines Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 146927 [details] [review] Bug 31450: (follow-up) Add hint about empty publication date This patch adds a hint to the additional contents form when the user is adding a news item, "News without a publication date will not display." This patch also makes to extra changes: Changing the grammatically incorrect heading "Modify an additional content" to "Modify additional content." The patch also splits the expiration date hint into two separate div.hint containers for better readability. To test, apply the patch and add a new news item. You should see the new hint under the publication date field. Try adding an HTML customization. The hint should not appear.
With the patch, my HTML customization with publication date in the future is displayed. Without the patch HTML customization - pub date today - Displayed - OK HTML customization - pub date tomorrow - Not displayed - OK HTML customization - no pub date - Not displayed - Not OK News - pub date today - Displayed - OK News - pub date tomorrow - Not displayed - OK News - no pub date - Not displayed - OK With the patch HTML customization - pub date today - Displayed - OK HTML customization - pub date tomorrow - Displayed - Not OK HTML customization - no pub date - Displayed - OK News - pub date today - Displayed - OK News - pub date tomorrow - Not displayed - OK News - no pub date - Not displayed - OK https://snipboard.io/H8rGQj.jpg
Setting to failed QA - I believe if a pubdate is set, it should be respected.
Created attachment 167754 [details] [review] Bug 31450: HTML customizations and News will not display on OPAC without Publication date To test: 1) Create some HTML Customizations and some News items that are set to display on the OPAC. Create one of each: [ 'With publication date today', 'With publication date in the future', 'Without publication date' ] 2) Note that news with publication date 'today' will display; with publication date 'in the future' will not display; with publication date unset will not display. 3) Note that html_customizations with date 'today' will display; with publication date 'in the future' will not display; with publication date unset will display. 4) Sign-Off Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 167755 [details] [review] Bug 31450: Remove some debug lines Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 167756 [details] [review] Bug 31450: (follow-up) Add hint about empty publication date This patch adds a hint to the additional contents form when the user is adding a news item, "News without a publication date will not display." This patch also makes to extra changes: Changing the grammatically incorrect heading "Modify an additional content" to "Modify additional content." The patch also splits the expiration date hint into two separate div.hint containers for better readability. To test, apply the patch and add a new news item. You should see the new hint under the publication date field. Try adding an HTML customization. The hint should not appear.
Rebased, but comment 13 is still valid: > With the patch > > HTML customization - pub date today - Displayed - OK > HTML customization - pub date tomorrow - Displayed - Not OK > HTML customization - no pub date - Displayed - OK > News - pub date today - Displayed - OK > News - pub date tomorrow - Not displayed - OK > News - no pub date - Not displayed - OK
Wouldn't it be possible and slightly easier just to make the publication date field required so it has to have data before submitting? Or is the issue here more so that it shouldn't even be required in the first place?
(In reply to Sam Lau from comment #19) > Wouldn't it be possible and slightly easier just to make the publication > date field required so it has to have data before submitting? Or is the > issue here more so that it shouldn't even be required in the first place? I think making the field required is a simple and effective solution to the problem.