If ones tries to resolve a claim from patrons detail page, "Resolve return claim" pop up isn't displayed. Page just jumps to the top of the page. However this works from the patron check out page. To reproduce: 1. Find patron with claims (or create them). 2. Navigate to patrons detail page and from there open "Claims" tab. 3. Press "Resolve" button. => Pop up isn't displayed and page jumps to the top of the page. 4. Repeat from patrons check out page. => Pop up is displayed.
I can't reproduce this bug in main
I was able reproduce this also in Biblibre sandbox. For some reason, even thought both patron Detail and Check out pages share the same code to create "Resolve" button and display pop up module, in Detail page clicking "Resolve" doesn't launch click function in resolve_claim_modal.js (first line).
This happens when ClaimReturnedLostValue syspref is not enabled. In moremember.tt line 765 we only check if ClaimReturnedLostValue is enabled. In circulation.tt line 1023 we check if either ClaimReturnedLostValue _or_ BundleLostValue syspref is enabled. Here's updated plan to reproduce this bug: 1. Disable syspref "ClaimReturnedLostValue" (set used value empty). 2. Find patron with claims (or create them). 3. Navigate to patrons detail page and from there open "Claims" tab. 4. Press "Resolve" button. => Pop up isn't displayed and page jumps to the top of the page. 5. Repeat from patrons check out page. => Pop up is displayed.
Created attachment 171301 [details] [review] Bug 37866: Unable to resolve claim from patron details page if syspref ClaimReturnedLostValue is disabled If ones tries to resolve a claim from patrons detail page and syspref ClaimReturnedLostValue is disabled, "Resolve return claim" pop up isn't displayed. Page just jumps to the top of the page. However this works from the patron check out page. This happens because in moremember.tt line 765 we only check if ClaimReturnedLostValue is enabled. In circulation.tt line 1023 we check if either ClaimReturnedLostValue or BundleLostValue syspref is enabled. To test: 1. Disable syspref "ClaimReturnedLostValue" (set used value empty). 2. Find patron with claims (or create them). 3. Navigate to patrons detail page and from there open "Claims" tab. 4. Press "Resolve" button. => Pop up isn't displayed and page jumps to the top of the page. 5. Repeat steps on patrons check out page. => Pop up is displayed. 6. Apply this patch. => Pop up should now be displayed both in patrons details and check out pages. Sponsored-by: Koha-Suomi Oy
Created attachment 171352 [details] [review] Bug 37866: Unable to resolve claim from patron details page if syspref ClaimReturnedLostValue is disabled If ones tries to resolve a claim from patrons detail page and syspref ClaimReturnedLostValue is disabled, "Resolve return claim" pop up isn't displayed. Page just jumps to the top of the page. However this works from the patron check out page. This happens because in moremember.tt line 765 we only check if ClaimReturnedLostValue is enabled. In circulation.tt line 1023 we check if either ClaimReturnedLostValue or BundleLostValue syspref is enabled. To test: 1. Disable syspref "ClaimReturnedLostValue" (set used value empty). 2. Find patron with claims (or create them). 3. Navigate to patrons detail page and from there open "Claims" tab. 4. Press "Resolve" button. => Pop up isn't displayed and page jumps to the top of the page. 5. Repeat steps on patrons check out page. => Pop up is displayed. 6. Apply this patch. => Pop up should now be displayed both in patrons details and check out pages. Sponsored-by: Koha-Suomi Oy Signed-off-by: Owen Leonard <oleonard@myacpl.org>
I was thinking about this some more, is it really wise to prevent pop up from launching if syspref is off but still display button in UI? It's kinda confusing for the user to have button there but no any kind of hint why it's not working.
(In reply to Emmi Takkinen from comment #6) > I was thinking about this some more, is it really wise to prevent pop up > from launching if syspref is off but still display button in UI? It's kinda > confusing for the user to have button there but no any kind of hint why it's > not working. Looks like the bug was a missed case from 66b35f50 - Bug 28854: Enable claims return view when BundleLostValue is set. The button (actually, all return claims functionality) is hidden if both ClaimReturnedLostValue and BundleLostValue are empty. So this should be fine - the check for BundleLostValue just got missed in this spot, causing the modal to not load when it should have.
Created attachment 174438 [details] [review] Bug 37866: Unable to resolve claim from patron details page if syspref ClaimReturnedLostValue is disabled If ones tries to resolve a claim from patrons detail page and syspref ClaimReturnedLostValue is disabled, "Resolve return claim" pop up isn't displayed. Page just jumps to the top of the page. However this works from the patron check out page. This happens because in moremember.tt line 765 we only check if ClaimReturnedLostValue is enabled. In circulation.tt line 1023 we check if either ClaimReturnedLostValue or BundleLostValue syspref is enabled. To test: 1. Disable syspref "ClaimReturnedLostValue" (set used value empty). 2. Find patron with claims (or create them). 3. Navigate to patrons detail page and from there open "Claims" tab. 4. Press "Resolve" button. => Pop up isn't displayed and page jumps to the top of the page. 5. Repeat steps on patrons check out page. => Pop up is displayed. 6. Apply this patch. => Pop up should now be displayed both in patrons details and check out pages. Sponsored-by: Koha-Suomi Oy Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Created attachment 174439 [details] [review] Bug 37866: (QA follow-up) Fix another missed case Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Pushed for 24.11! Well done everyone, thank you!