Bug 38082 - Advanced editor does not save the selected framework with new record
Summary: Advanced editor does not save the selected framework with new record
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: unspecified
Hardware: All All
: P3 normal
Assignee: Janusz Kaczmarek
QA Contact: Emily Lamancusa (emlam)
URL:
Keywords:
: 37948 (view as bug list)
Depends on: 36351
Blocks:
  Show dependency treegraph
 
Reported: 2024-10-03 18:21 UTC by Janusz Kaczmarek
Modified: 2025-01-02 09:52 UTC (History)
12 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.06
Circulation function:


Attachments
Bug 38082: Advanced editor does not save the selected framework (1.72 KB, patch)
2024-10-03 18:46 UTC, Janusz Kaczmarek
Details | Diff | Splinter Review
Bug 38082: Advanced editor does not save the selected framework (1.77 KB, patch)
2024-10-03 20:33 UTC, Roman Dolny
Details | Diff | Splinter Review
Bug 38082: Advanced editor does not save the selected framework (1.84 KB, patch)
2024-10-21 15:04 UTC, Emily Lamancusa (emlam)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Janusz Kaczmarek 2024-10-03 18:21:07 UTC
When creating a fresh record in the advanced editor, it does not save the framework selected from the Settings dropdown.
Comment 1 Janusz Kaczmarek 2024-10-03 18:46:14 UTC
Created attachment 172367 [details] [review]
Bug 38082: Advanced editor does not save the selected framework

When creating a fresh record in the advanced editor, it does not
save the framework selected from the Settings dropdown.

Test plan:
==========

1. Enable the advanced editor feature (EnableAdvancedCatalogingEditor).
2. Start editing a new record in the advanced editor.  Fill in the
   mandatory fields, select a framework (other than Default) from the
   Settings dropdown, save the record.
3. Select view -- note that the record has been saved with the Default
   framework.
4. Apply the patch; restart_all; refresh the browser window.
5. Repeat p. 2.
6. Select view -- you should now see that the record has been saved with
   the correct, selected framework.
Comment 2 Janusz Kaczmarek 2024-10-03 18:59:33 UTC
(In reply to Janusz Kaczmarek from comment #0)
> When creating a fresh record in the advanced editor, it does not save the
> framework selected from the Settings dropdown.

NB, this is due to the bug 36351 -- it is there that the question mark in the URL ("new_bib?frameworkcode") has been replaced by a slash.
Comment 3 Roman Dolny 2024-10-03 20:33:50 UTC
Created attachment 172372 [details] [review]
Bug 38082: Advanced editor does not save the selected framework

When creating a fresh record in the advanced editor, it does not
save the framework selected from the Settings dropdown.

Test plan:
==========

1. Enable the advanced editor feature (EnableAdvancedCatalogingEditor).
2. Start editing a new record in the advanced editor.  Fill in the
   mandatory fields, select a framework (other than Default) from the
   Settings dropdown, save the record.
3. Select view -- note that the record has been saved with the Default
   framework.
4. Apply the patch; restart_all; refresh the browser window.
5. Repeat p. 2.
6. Select view -- you should now see that the record has been saved with
   the correct, selected framework.

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 4 Isabel Pineda 2024-10-08 21:55:26 UTC
I would like to add a comment:

Since Koha version 24.05.04:
When opening an existing record that was saved with a specific framework (not the default one), the record opens in the default framework.
Comment 5 Angela Berrett 2024-10-14 17:36:06 UTC
(In reply to Isabel Pineda from comment #4)
> I would like to add a comment:
> 
> Since Koha version 24.05.04:
> When opening an existing record that was saved with a specific framework
> (not the default one), the record opens in the default framework.

We have noticed this too.  We put in a ticket with ByWater Solutions, but it doesn't happen consistently, and once you've opened and closed the record a couple of times it eventually opens correctly.
Comment 6 Janusz Kaczmarek 2024-10-14 18:12:32 UTC
(In reply to Angela Berrett from comment #5)
> (In reply to Isabel Pineda from comment #4)
> > I would like to add a comment:
> > 
> > Since Koha version 24.05.04:
> > When opening an existing record that was saved with a specific framework
> > (not the default one), the record opens in the default framework.
> 
> We have noticed this too.  We put in a ticket with ByWater Solutions, but it
> doesn't happen consistently, and once you've opened and closed the record a
> couple of times it eventually opens correctly.

This sounds and looks like--technically--a separate, unrelated issue.  Could you please file a new bug?
Comment 7 Isabel Pineda 2024-10-14 19:12:38 UTC
Ok, @Janusz Kaczmarek. I have just filed the bug 38168. 
Thank you.
Comment 8 Phil Ringnalda 2024-10-17 00:24:07 UTC
*** Bug 37948 has been marked as a duplicate of this bug. ***
Comment 9 Emily Lamancusa (emlam) 2024-10-21 15:04:40 UTC
Created attachment 173067 [details] [review]
Bug 38082: Advanced editor does not save the selected framework

When creating a fresh record in the advanced editor, it does not
save the framework selected from the Settings dropdown.

Test plan:
==========

1. Enable the advanced editor feature (EnableAdvancedCatalogingEditor).
2. Start editing a new record in the advanced editor.  Fill in the
   mandatory fields, select a framework (other than Default) from the
   Settings dropdown, save the record.
3. Select view -- note that the record has been saved with the Default
   framework.
4. Apply the patch; restart_all; refresh the browser window.
5. Repeat p. 2.
6. Select view -- you should now see that the record has been saved with
   the correct, selected framework.

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 10 Katrin Fischer 2024-10-22 10:10:10 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 11 Phil Ringnalda 2024-11-06 00:47:05 UTC
The dependency on bug 38057 was only to have a working framework menu on main, to be able to see what you were setting. It isn't required to get this on 24.05, which is affected and needs it.
Comment 12 Lucas Gass (lukeg) 2024-11-20 18:26:43 UTC
Backported to 24.05.x for upcoming 24.05.06
Comment 13 Fridolin Somers 2024-12-13 14:43:55 UTC
Depends on bug 36351 not in 23.11.x
Comment 14 Aude Charillon 2025-01-02 09:52:09 UTC
No update to Koha Manual needed.