t/db_dependent/Reserves.t .. 10/70 No reserves HOLD_CANCELLATION letter transported by email at /kohadevbox/koha/C4/Letters.pm line 602.
Created attachment 184076 [details] [review] Bug 40373: Remove warning from Reserves.t t/db_dependent/Reserves.t .. 10/70 No reserves HOLD_CANCELLATION letter transported by email at /kohadevbox/koha/C4/Letters.pm line 602. We do not test the notification here, we can simply ignore the letters code. However we do test it later so we need to limit the scope of mock
Created attachment 184241 [details] [review] Bug 40373: Remove warning from Reserves.t t/db_dependent/Reserves.t .. 10/70 No reserves HOLD_CANCELLATION letter transported by email at /kohadevbox/koha/C4/Letters.pm line 602. We do not test the notification here, we can simply ignore the letters code. However we do test it later so we need to limit the scope of mock Signed-off-by: David Nind <david@davidnind.com>
Created attachment 184278 [details] [review] Bug 40373: Remove warning from Reserves.t t/db_dependent/Reserves.t .. 10/70 No reserves HOLD_CANCELLATION letter transported by email at /kohadevbox/koha/C4/Letters.pm line 602. We do not test the notification here, we can simply ignore the letters code. However we do test it later so we need to limit the scope of mock Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
QA Comment: I dont mind adding this patch. And welcome NoWarnings. But if we would be adding mocks to eliminate those warnings, we might miss the initial goal of adding NoWarnings? It feels like solving at the wrong place..
(In reply to Marcel de Rooy from comment #4) > QA Comment: I dont mind adding this patch. And welcome NoWarnings. But if we > would be adding mocks to eliminate those warnings, we might miss the initial > goal of adding NoWarnings? It feels like solving at the wrong place.. Yes, I understand what you meant and I hesitated with that one. However the goal is really to have NoWarnings everywhere. I added the comment in the code and a note on bug 26282 comment 122 about this.
Nice work everyone! Pushed to main for 25.11
Nice work everyone! Pushed to 25.05.x
Pushed to 24.11.x for 24.11.08