Bug 40373 - Reserves.t generates a warning
Summary: Reserves.t generates a warning
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor
Assignee: Jonathan Druart
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks: 40444
  Show dependency treegraph
 
Reported: 2025-07-15 09:20 UTC by Jonathan Druart
Modified: 2025-08-01 09:56 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00,25.05.02,24.11.08
Circulation function:


Attachments
Bug 40373: Remove warning from Reserves.t (1.57 KB, patch)
2025-07-15 09:21 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40373: Remove warning from Reserves.t (1.62 KB, patch)
2025-07-17 22:00 UTC, David Nind
Details | Diff | Splinter Review
Bug 40373: Remove warning from Reserves.t (1.71 KB, patch)
2025-07-18 06:36 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2025-07-15 09:20:27 UTC
t/db_dependent/Reserves.t .. 10/70 No reserves HOLD_CANCELLATION letter transported by email at /kohadevbox/koha/C4/Letters.pm line 602.
Comment 1 Jonathan Druart 2025-07-15 09:21:45 UTC
Created attachment 184076 [details] [review]
Bug 40373: Remove warning from Reserves.t

t/db_dependent/Reserves.t .. 10/70 No reserves HOLD_CANCELLATION letter transported by email at /kohadevbox/koha/C4/Letters.pm line 602.

We do not test the notification here, we can simply ignore the letters code.
However we do test it later so we need to limit the scope of mock
Comment 2 David Nind 2025-07-17 22:00:08 UTC
Created attachment 184241 [details] [review]
Bug 40373: Remove warning from Reserves.t

t/db_dependent/Reserves.t .. 10/70 No reserves HOLD_CANCELLATION letter transported by email at /kohadevbox/koha/C4/Letters.pm line 602.

We do not test the notification here, we can simply ignore the letters code.
However we do test it later so we need to limit the scope of mock

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Marcel de Rooy 2025-07-18 06:36:53 UTC
Created attachment 184278 [details] [review]
Bug 40373: Remove warning from Reserves.t

t/db_dependent/Reserves.t .. 10/70 No reserves HOLD_CANCELLATION letter transported by email at /kohadevbox/koha/C4/Letters.pm line 602.

We do not test the notification here, we can simply ignore the letters code.
However we do test it later so we need to limit the scope of mock

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Marcel de Rooy 2025-07-18 06:39:10 UTC
QA Comment: I dont mind adding this patch. And welcome NoWarnings. But if we would be adding mocks to eliminate those warnings, we might miss the initial goal of adding NoWarnings? It feels like solving at the wrong place..
Comment 5 Jonathan Druart 2025-07-18 09:28:23 UTC
(In reply to Marcel de Rooy from comment #4)
> QA Comment: I dont mind adding this patch. And welcome NoWarnings. But if we
> would be adding mocks to eliminate those warnings, we might miss the initial
> goal of adding NoWarnings? It feels like solving at the wrong place..

Yes, I understand what you meant and I hesitated with that one.

However the goal is really to have NoWarnings everywhere. I added the comment in the code and a note on bug 26282 comment 122 about this.
Comment 6 Lucas Gass (lukeg) 2025-07-18 17:11:56 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 7 Paul Derscheid 2025-07-24 08:21:01 UTC
Nice work everyone!

Pushed to 25.05.x
Comment 8 Fridolin Somers 2025-08-01 09:56:38 UTC
Pushed to 24.11.x for 24.11.08