Bug 40517 - Allow grouping existing holds
Summary: Allow grouping existing holds
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Pedro Amorim
QA Contact: Testopia
URL: https://github.com/openfifth/koha/com...
Keywords:
Depends on: 15516 40395
Blocks:
  Show dependency treegraph
 
Reported: 2025-07-25 14:23 UTC by Pedro Amorim
Modified: 2025-07-25 14:38 UTC (History)
8 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 40517: Add hold groups relationship to patron (6.49 KB, patch)
2025-07-25 14:38 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 40517: Move creation of hold group into Patron class. Add exceptions (10.23 KB, patch)
2025-07-25 14:38 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 40517: REST API: Hold groups endpoint (18.90 KB, patch)
2025-07-25 14:38 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 40517: Add visual_group_id to hold_groups (9.14 KB, patch)
2025-07-25 14:38 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 40517: Patron holds table: Add 'group selected holds' functionality (16.88 KB, patch)
2025-07-25 14:38 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 40517: Patron page holds table buttons rearrangement (8.12 KB, patch)
2025-07-25 14:38 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 40517: Add unit tests (5.64 KB, patch)
2025-07-25 14:38 UTC, Pedro Amorim
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2025-07-25 14:23:24 UTC

    
Comment 1 Pedro Amorim 2025-07-25 14:38:28 UTC
Created attachment 184640 [details] [review]
Bug 40517: Add hold groups relationship to patron
Comment 2 Pedro Amorim 2025-07-25 14:38:31 UTC
Created attachment 184641 [details] [review]
Bug 40517: Move creation of hold group into Patron class. Add exceptions

Refactor: Update controller logic to make use of patron->create_hold_group

This ensures consistency when creating a new hold group for a patron,
regardless if on the Staff UI or REST API
Comment 3 Pedro Amorim 2025-07-25 14:38:34 UTC
Created attachment 184642 [details] [review]
Bug 40517: REST API: Hold groups endpoint

list and add actions:
/patrons/{patron_id}/hold_groups

New test file:
prove t/db_dependent/api/v1/patrons_hold_groups.t
Comment 4 Pedro Amorim 2025-07-25 14:38:36 UTC
Created attachment 184643 [details] [review]
Bug 40517: Add visual_group_id to hold_groups
Comment 5 Pedro Amorim 2025-07-25 14:38:40 UTC
Created attachment 184644 [details] [review]
Bug 40517: Patron holds table: Add 'group selected holds' functionality

This adds the UI elements required to group selected holds from the
patron pages as well as 2 new concepts:

Visual group ID:
The visual group ID is designed to be easy to understand from a UI/UX
perspective and not show the user an indefinitely incremented value.
When holds are cancelled, filled or moved to a different group, if the
old group is left empty or with a single hold, the hold group is deleted.
Comment 6 Pedro Amorim 2025-07-25 14:38:43 UTC
Created attachment 184645 [details] [review]
Bug 40517: Patron page holds table buttons rearrangement

This table now has 4 total buttons, 3 of which relate to a selection of
holds. Rearranging the buttons is now necessary to present them nicely.
Comment 7 Pedro Amorim 2025-07-25 14:38:45 UTC
Created attachment 184646 [details] [review]
Bug 40517: Add unit tests

Run the updated test file:
prove ./t/db_dependent/Koha/Patron.t

Relevant tests worth running to ensure no regressions are added to existing covered functionality:
prove ./t/db_dependent/Circulation*
prove ./t/db_dependent/Hold*
prove ./t/db_dependent/Reserves*

Test plan, k-t-d:
1) Apply patches, enable DisplayAddHoldGroups system preference
2) Do a search for 'test':
<staff_url>/cgi-bin/koha/catalogue/search.pl?q=test
3) Click the 'Select all' link at the top of the search results, click the 'Place hold' button.
4) Enter the 'koha' user
5) Pick a pickup location for each of the holds and click 'Place holds'.
6) Visit the 'koha' patron:
<staff_url>/cgi-bin/koha/members/moremember.pl?borrowernumber=51
7) Click the 'holds' tab. Notice a new 'Group selected' button now exists
8) Pick any number of holds (more than 2) and click the 'Group selected' button. Confirm
9) Notice the hold group shows '1'. If you click on it you're presented the hold group modal.
10) Group multiple holds multiple times.
11) Notice you can't group a hold that has already been found.
12) Notice you can't click the 'Group selected' button unless at least 2 holds are selected.
13) Notice a hold group is deleted if left with 0 or 1 hold e.g. make a group of 2 holds, cancel 1, notice the remaining hold is left without a group.

prove t/db_dependent/api/v1/patrons_hold_groups.t
prove t/db_dependent/Koha/Patron.t