See http://wiki.koha-community.org/wiki/Digital_signs_RFC for details.
Created attachment 42703 [details] [review] Bug 8628: Add digital signs to the OPAC, dbchanges Database changes for bug 8628
Created attachment 42704 [details] [review] Bug 8628: Add digital signs to the OPAC See http://wiki.koha-community.org/wiki/Digital_signs_RFC for details. To test: 1. Apply this patch and the database updates patch 2. Run updatedatabase.pl 3. In staff client, go to Tools/Additional Tools/Digital signs 4. You should be warned about OPACDigitalSigns not being enabled, you can ignore this for now. 5. Add a new sign by clicking the "+ New sign" button 6. Enter a name and optionally numbers for automatic page turing 7. Your new sign should appear in the Signs list 8. Add a new stream by clicking the "+ New stream" button 9. Unless you already have reports in the report group with code SIG, you should be warned that there are no reports in the group with code SIG and given a link for creating a new report. Follow the link and create a new report with report group code SIG. En example SQL command for the report could be: SELECT * FROM biblio WHERE timestamp > DATE_SUB(NOW(), INTERVAL 7 DAY) 10. Go back to the "new stream" page, and reload. You should no longer see a warning message, and your newly created report should appear in the list of reports. 11. Select the report and click Submit. Your newly created stream should now appear in the list of streams. 12. In the list of signs, press "edit streams" for the sign you previously created. 13. Choose a stream to attach and click Submit. Your sign is now ready for OPAC. 14. In OPAC, visit /cgi-bin/koha/opac-signs.pl 15. You should be told that Digital signs are not enabled. Enable with new system preference OPACDigitalSigns and reload the page. 15. You should see a list of available signs, click on a sign that you wish to display. 16. You should now see a list of all books matching the SQL query in the report that you attached to your stream. 17. If you have OPACLocalCoverImages enabled, all books with local covers attached should be presented using this cover. If no local cover is available and the book has a ISBN with a cover in openlibrary.org, the cover image from openlibrary.org should be shown. If all of the above fails, a cover matching the theme of the page should be seen, showing the book title and author. 18. Clicking a book should bring you to a detailed view of the book where you can see the books availability. You should also see the two next books and the two previous books in the stream (unless you're at the beginning or end of the stream) 19. Swiping (if no touch screen, click and hold left mouse button and drag) left/right should bring you to next/previous book. Clicking on the next/previous books (right/left of the active one) should bring you to the detailed view of the clicked book. 20. Leaving the page idle (i.e no user interaction) for the amount of time specified in step 6. should result in the page automatically switching to the next book in the stream. Sponsored-by: Regionbibliotek Halland / County library of Halland
Created attachment 45968 [details] [review] Bug 8628: Add digital signs to the OPAC, dbchanges Database changes for bug 8628 Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Created attachment 45969 [details] [review] Bug 8628: Add digital signs to the OPAC See http://wiki.koha-community.org/wiki/Digital_signs_RFC for details. To test: 1. Apply this patch and the database updates patch 2. Run updatedatabase.pl 3. In staff client, go to Tools/Additional Tools/Digital signs 4. You should be warned about OPACDigitalSigns not being enabled, you can ignore this for now. 5. Add a new sign by clicking the "+ New sign" button 6. Enter a name and optionally numbers for automatic page turing 7. Your new sign should appear in the Signs list 8. Add a new stream by clicking the "+ New stream" button 9. Unless you already have reports in the report group with code SIG, you should be warned that there are no reports in the group with code SIG and given a link for creating a new report. Follow the link and create a new report with report group code SIG. En example SQL command for the report could be: SELECT * FROM biblio WHERE timestamp > DATE_SUB(NOW(), INTERVAL 7 DAY) 10. Go back to the "new stream" page, and reload. You should no longer see a warning message, and your newly created report should appear in the list of reports. 11. Select the report and click Submit. Your newly created stream should now appear in the list of streams. 12. In the list of signs, press "edit streams" for the sign you previously created. 13. Choose a stream to attach and click Submit. Your sign is now ready for OPAC. 14. In OPAC, visit /cgi-bin/koha/opac-signs.pl 15. You should be told that Digital signs are not enabled. Enable with new system preference OPACDigitalSigns and reload the page. 15. You should see a list of available signs, click on a sign that you wish to display. 16. You should now see a list of all books matching the SQL query in the report that you attached to your stream. 17. If you have OPACLocalCoverImages enabled, all books with local covers attached should be presented using this cover. If no local cover is available and the book has a ISBN with a cover in openlibrary.org, the cover image from openlibrary.org should be shown. If all of the above fails, a cover matching the theme of the page should be seen, showing the book title and author. 18. Clicking a book should bring you to a detailed view of the book where you can see the books availability. You should also see the two next books and the two previous books in the stream (unless you're at the beginning or end of the stream) 19. Swiping (if no touch screen, click and hold left mouse button and drag) left/right should bring you to next/previous book. Clicking on the next/previous books (right/left of the active one) should bring you to the detailed view of the clicked book. 20. Leaving the page idle (i.e no user interaction) for the amount of time specified in step 6. should result in the page automatically switching to the next book in the stream. Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> In theory this could/should be rewritten to use Koha::Schema instead of direct sql, but this predates the switch, so would be unfair to reject it on that basis (plus until we fix the speed straight sql is way faster anyway)
Martin, Following the coding guidelines, new modules added to the Koha namespace should be object-oriented. You should have a look at Koha::Object ( see Koha::Patron::Categories and Koha::Virtualshel* for examples).
Created attachment 58602 [details] [review] Bug 8628: [FOLLOW-UP] Add digital signs to the OPAC This patch rewrites all modules from the original patch to be object oriented. Follows above test plan. Sponsored-by: Region Halland
Created attachment 58603 [details] [review] Bug 8628: Add digital signs to the OPAC, dbchanges Database changes for bug 8628 Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Created attachment 58604 [details] [review] Bug 8628: Add digital signs to the OPAC See http://wiki.koha-community.org/wiki/Digital_signs_RFC for details. To test: 1. Apply this patch and the database updates patch 2. Run updatedatabase.pl 3. In staff client, go to Tools/Additional Tools/Digital signs 4. You should be warned about OPACDigitalSigns not being enabled, you can ignore this for now. 5. Add a new sign by clicking the "+ New sign" button 6. Enter a name and optionally numbers for automatic page turing 7. Your new sign should appear in the Signs list 8. Add a new stream by clicking the "+ New stream" button 9. Unless you already have reports in the report group with code SIG, you should be warned that there are no reports in the group with code SIG and given a link for creating a new report. Follow the link and create a new report with report group code SIG. En example SQL command for the report could be: SELECT * FROM biblio WHERE timestamp > DATE_SUB(NOW(), INTERVAL 7 DAY) 10. Go back to the "new stream" page, and reload. You should no longer see a warning message, and your newly created report should appear in the list of reports. 11. Select the report and click Submit. Your newly created stream should now appear in the list of streams. 12. In the list of signs, press "edit streams" for the sign you previously created. 13. Choose a stream to attach and click Submit. Your sign is now ready for OPAC. 14. In OPAC, visit /cgi-bin/koha/opac-signs.pl 15. You should be told that Digital signs are not enabled. Enable with new system preference OPACDigitalSigns and reload the page. 15. You should see a list of available signs, click on a sign that you wish to display. 16. You should now see a list of all books matching the SQL query in the report that you attached to your stream. 17. If you have OPACLocalCoverImages enabled, all books with local covers attached should be presented using this cover. If no local cover is available and the book has a ISBN with a cover in openlibrary.org, the cover image from openlibrary.org should be shown. If all of the above fails, a cover matching the theme of the page should be seen, showing the book title and author. 18. Clicking a book should bring you to a detailed view of the book where you can see the books availability. You should also see the two next books and the two previous books in the stream (unless you're at the beginning or end of the stream) 19. Swiping (if no touch screen, click and hold left mouse button and drag) left/right should bring you to next/previous book. Clicking on the next/previous books (right/left of the active one) should bring you to the detailed view of the clicked book. 20. Leaving the page idle (i.e no user interaction) for the amount of time specified in step 6. should result in the page automatically switching to the next book in the stream. Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> In theory this could/should be rewritten to use Koha::Schema instead of direct sql, but this predates the switch, so would be unfair to reject it on that basis (plus until we fix the speed straight sql is way faster anyway)
Created attachment 58605 [details] [review] Bug 8628: [FOLLOW-UP] Add digital signs to the OPAC This patch rewrites all modules from the original patch to be object oriented. Follows above test plan. Sponsored-by: Region Halland
This patch should now apply cleanly and is ready for testing.
Created attachment 62338 [details] [review] Bug 8628: [FOLLOW-UP] Add digital signs to the OPAC This patch rewrites all modules from the original patch to be object oriented. Follows above test plan. Sponsored-by: Region Halland
The QA scripts are pointing out some issues with these patches: FAIL installer/data/mysql/atomicupdate/bug_8628-digital-signs-sysprefs.sql OK git manipulation FAIL semicolon simicolon found instead of comma at line 1 simicolon found instead of comma at line 3 simicolon found instead of comma at line 2 OK sysprefs_order FAIL installer/data/mysql/kohastructure.sql FAIL charset_collate The table sign_streams does not have the current charset collate (see bug 11944) The table signs_to_streams does not have the current charset collate (see bug 11944) The table signs does not have the current charset collate (see bug 11944) OK git manipulation OK installer/data/mysql/sysprefs.sql OK git manipulation OK semicolon OK sysprefs_order OK koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt FAIL forbidden patterns forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 407) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 441) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 227) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 86) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 87) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 226) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 442) OK git manipulation OK spelling OK tt_valid OK valid_template OK koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-signs.tt FAIL forbidden patterns forbidden pattern: simple-quote string (line 468) forbidden pattern: opac-tmpl should certainly replaced with [% interface %] (line 561) forbidden pattern: opac-tmpl should certainly replaced with [% interface %] (line 67) forbidden pattern: simple-quote string (line 464) forbidden pattern: simple-quote string (line 448) forbidden pattern: simple-quote string (line 450) forbidden pattern: simple-quote string (line 465) forbidden pattern: opac-tmpl should certainly replaced with [% interface %] (line 462) forbidden pattern: opac-tmpl should certainly replaced with [% interface %] (line 70) forbidden pattern: simple-quote string (line 478) forbidden pattern: opac-tmpl should certainly replaced with [% interface %] (line 69) OK git manipulation FAIL spelling initilize ==> initialize OK tt_valid OK valid_template FAIL opac/opac-signs.pl OK critic FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 9) OK git manipulation OK pod OK spelling OK valid FAIL tools/signs.pl OK critic FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 9) OK git manipulation OK pod OK spelling OK valid
Took a quick look at the code of the patches too: 1) There is an atomicupdate for adding a new permission edit_digital_signs, but no corresponding change to koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc 2) Maybe a merge issue, but sysprefs.sql removes 2 existing system preferences and doesn't add the new ones? 3) There is a comment about YUI - maybe that can just be thrown out? + // prepare DOM for YUI Toolbar 4) the borrow permission is used in opac-signs.pl but has since been removed.
Created attachment 64249 [details] [review] Bug 8628: [FOLLOW-UP] More fixes This patch fixes qa tool issues, problems in comment 13, merge conflicts, other issues with patches Same test plan applies
I tried to fix the conflicts in kohastructure.sql, but ended with: Apply? [(y)es, (n)o, (i)nteractive] i Applying: Bug 8628: [FOLLOW-UP] More fixes fatal: sha1 information is lacking or useless (installer/data/mysql/kohastructure.sql). error: could not build fake ancestor Patch failed at 0001 Bug 8628: [FOLLOW-UP] More fixes The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-8628-FOLLOW-UP-More-fixes-banEXL.patch Can you please take a look?
Created attachment 66246 [details] [review] Bug 8628: [FOLLOW-UP] Add digital signs to the OPAC This patch rewrites all modules from the original patch to be object oriented. Follows above test plan. Sponsored-by: Region Halland
Created attachment 66247 [details] [review] Bug 8628: Add digital signs to the OPAC, dbchanges Database changes for bug 8628 Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Created attachment 66248 [details] [review] Bug 8628: Add digital signs to the OPAC See http://wiki.koha-community.org/wiki/Digital_signs_RFC for details. To test: 1. Apply this patch and the database updates patch 2. Run updatedatabase.pl 3. In staff client, go to Tools/Additional Tools/Digital signs 4. You should be warned about OPACDigitalSigns not being enabled, you can ignore this for now. 5. Add a new sign by clicking the "+ New sign" button 6. Enter a name and optionally numbers for automatic page turing 7. Your new sign should appear in the Signs list 8. Add a new stream by clicking the "+ New stream" button 9. Unless you already have reports in the report group with code SIG, you should be warned that there are no reports in the group with code SIG and given a link for creating a new report. Follow the link and create a new report with report group code SIG. En example SQL command for the report could be: SELECT * FROM biblio WHERE timestamp > DATE_SUB(NOW(), INTERVAL 7 DAY) 10. Go back to the "new stream" page, and reload. You should no longer see a warning message, and your newly created report should appear in the list of reports. 11. Select the report and click Submit. Your newly created stream should now appear in the list of streams. 12. In the list of signs, press "edit streams" for the sign you previously created. 13. Choose a stream to attach and click Submit. Your sign is now ready for OPAC. 14. In OPAC, visit /cgi-bin/koha/opac-signs.pl 15. You should be told that Digital signs are not enabled. Enable with new system preference OPACDigitalSigns and reload the page. 15. You should see a list of available signs, click on a sign that you wish to display. 16. You should now see a list of all books matching the SQL query in the report that you attached to your stream. 17. If you have OPACLocalCoverImages enabled, all books with local covers attached should be presented using this cover. If no local cover is available and the book has a ISBN with a cover in openlibrary.org, the cover image from openlibrary.org should be shown. If all of the above fails, a cover matching the theme of the page should be seen, showing the book title and author. 18. Clicking a book should bring you to a detailed view of the book where you can see the books availability. You should also see the two next books and the two previous books in the stream (unless you're at the beginning or end of the stream) 19. Swiping (if no touch screen, click and hold left mouse button and drag) left/right should bring you to next/previous book. Clicking on the next/previous books (right/left of the active one) should bring you to the detailed view of the clicked book. 20. Leaving the page idle (i.e no user interaction) for the amount of time specified in step 6. should result in the page automatically switching to the next book in the stream. Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> In theory this could/should be rewritten to use Koha::Schema instead of direct sql, but this predates the switch, so would be unfair to reject it on that basis (plus until we fix the speed straight sql is way faster anyway)
Created attachment 66249 [details] [review] Bug 8628: [FOLLOW-UP] More fixes This patch fixes qa tool issues, problems in comment 13, merge conflicts, other issues with patches Same test plan applies
Created attachment 66250 [details] [review] Bug 8628: [FOLLOW-UP] Add digital signs to the OPAC This patch rewrites all modules from the original patch to be object oriented. Follows above test plan. Sponsored-by: Region Halland
Sorry about all that - looks like the patches apply without conflicts now. Ready to test.
Is it correct that this bug depends on Bug 8630?
Trying to test :) - Nothing found in code review. - Database update works nicely. Not OK: - QA test tools give some bad results: FAIL Koha/Schema/Result/Sign.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage OK spelling OK valid FAIL Koha/Schema/Result/SignStream.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage OK spelling OK valid FAIL Koha/Schema/Result/SignsToStream.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage OK spelling OK valid FAIL Koha/Sign.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage OK spelling OK valid FAIL Koha/SignStream.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage OK spelling OK valid FAIL Koha/SignsToStream.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage OK spelling OK valid FAIL installer/data/mysql/atomicupdate/bug_8628-digital-signs-sysprefs.sql OK git manipulation FAIL semicolon OK sysprefs_order FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-signs.tt FAIL forbidden patterns OK git manipulation FAIL spelling OK tt_valid OK valid_template - On the /cgi-bin/koha/tools/signs.pl the datatable is broken (next page, etc.) - I think it would be nicer to use "SIGN" instead of "SIG" for the report group and include it in the sample values. - On point 16) of the test plan I receive an internal server error, so can't test the last steps: Can't use string ("1") as a HASH ref while "strict refs" in use at /home/vagrant/kohaclone/C4/Biblio.pm line 1182.
I wonder if this would be better as a plugin...
It might be an option. But I really wish we could fix the translation problem of plugins so that we can really have fun with them.
Created attachment 77025 [details] [review] Bug 8628: Add digital signs to the OPAC, dbchanges Database changes for bug 8628 Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Created attachment 77026 [details] [review] Bug 8628: Add digital signs to the OPAC See http://wiki.koha-community.org/wiki/Digital_signs_RFC for details. To test: 1. Apply this patch and the database updates patch 2. Run updatedatabase.pl 3. In staff client, go to Tools/Additional Tools/Digital signs 4. You should be warned about OPACDigitalSigns not being enabled, you can ignore this for now. 5. Add a new sign by clicking the "+ New sign" button 6. Enter a name and optionally numbers for automatic page turing 7. Your new sign should appear in the Signs list 8. Add a new stream by clicking the "+ New stream" button 9. Unless you already have reports in the report group with code SIG, you should be warned that there are no reports in the group with code SIG and given a link for creating a new report. Follow the link and create a new report with report group code SIG. En example SQL command for the report could be: SELECT * FROM biblio WHERE timestamp > DATE_SUB(NOW(), INTERVAL 7 DAY) 10. Go back to the "new stream" page, and reload. You should no longer see a warning message, and your newly created report should appear in the list of reports. 11. Select the report and click Submit. Your newly created stream should now appear in the list of streams. 12. In the list of signs, press "edit streams" for the sign you previously created. 13. Choose a stream to attach and click Submit. Your sign is now ready for OPAC. 14. In OPAC, visit /cgi-bin/koha/opac-signs.pl 15. You should be told that Digital signs are not enabled. Enable with new system preference OPACDigitalSigns and reload the page. 15. You should see a list of available signs, click on a sign that you wish to display. 16. You should now see a list of all books matching the SQL query in the report that you attached to your stream. 17. If you have OPACLocalCoverImages enabled, all books with local covers attached should be presented using this cover. If no local cover is available and the book has a ISBN with a cover in openlibrary.org, the cover image from openlibrary.org should be shown. If all of the above fails, a cover matching the theme of the page should be seen, showing the book title and author. 18. Clicking a book should bring you to a detailed view of the book where you can see the books availability. You should also see the two next books and the two previous books in the stream (unless you're at the beginning or end of the stream) 19. Swiping (if no touch screen, click and hold left mouse button and drag) left/right should bring you to next/previous book. Clicking on the next/previous books (right/left of the active one) should bring you to the detailed view of the clicked book. 20. Leaving the page idle (i.e no user interaction) for the amount of time specified in step 6. should result in the page automatically switching to the next book in the stream. Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> In theory this could/should be rewritten to use Koha::Schema instead of direct sql, but this predates the switch, so would be unfair to reject it on that basis (plus until we fix the speed straight sql is way faster anyway)
Created attachment 77027 [details] [review] Bug 8628: [FOLLOW-UP] More fixes This patch fixes qa tool issues, problems in comment 13, merge conflicts, other issues with patches Same test plan applies
Created attachment 77028 [details] [review] Bug 8628: [FOLLOW-UP] Add digital signs to the OPAC This patch rewrites all modules from the original patch to be object oriented. Follows above test plan. Sponsored-by: Region Halland
Created attachment 77141 [details] [review] Bug 8628: Add digital signs to the OPAC, dbchanges Database changes for bug 8628 Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Created attachment 77142 [details] [review] Bug 8628: Add digital signs to the OPAC See http://wiki.koha-community.org/wiki/Digital_signs_RFC for details. To test: 1. Apply this patch and the database updates patch 2. Run updatedatabase.pl 3. In staff client, go to Tools/Additional Tools/Digital signs 4. You should be warned about OPACDigitalSigns not being enabled, you can ignore this for now. 5. Add a new sign by clicking the "+ New sign" button 6. Enter a name and optionally numbers for automatic page turing 7. Your new sign should appear in the Signs list 8. Add a new stream by clicking the "+ New stream" button 9. Unless you already have reports in the report group with code SIG, you should be warned that there are no reports in the group with code SIG and given a link for creating a new report. Follow the link and create a new report with report group code SIG. En example SQL command for the report could be: SELECT * FROM biblio WHERE timestamp > DATE_SUB(NOW(), INTERVAL 7 DAY) 10. Go back to the "new stream" page, and reload. You should no longer see a warning message, and your newly created report should appear in the list of reports. 11. Select the report and click Submit. Your newly created stream should now appear in the list of streams. 12. In the list of signs, press "edit streams" for the sign you previously created. 13. Choose a stream to attach and click Submit. Your sign is now ready for OPAC. 14. In OPAC, visit /cgi-bin/koha/opac-signs.pl 15. You should be told that Digital signs are not enabled. Enable with new system preference OPACDigitalSigns and reload the page. 15. You should see a list of available signs, click on a sign that you wish to display. 16. You should now see a list of all books matching the SQL query in the report that you attached to your stream. 17. If you have OPACLocalCoverImages enabled, all books with local covers attached should be presented using this cover. If no local cover is available and the book has a ISBN with a cover in openlibrary.org, the cover image from openlibrary.org should be shown. If all of the above fails, a cover matching the theme of the page should be seen, showing the book title and author. 18. Clicking a book should bring you to a detailed view of the book where you can see the books availability. You should also see the two next books and the two previous books in the stream (unless you're at the beginning or end of the stream) 19. Swiping (if no touch screen, click and hold left mouse button and drag) left/right should bring you to next/previous book. Clicking on the next/previous books (right/left of the active one) should bring you to the detailed view of the clicked book. 20. Leaving the page idle (i.e no user interaction) for the amount of time specified in step 6. should result in the page automatically switching to the next book in the stream. Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> In theory this could/should be rewritten to use Koha::Schema instead of direct sql, but this predates the switch, so would be unfair to reject it on that basis (plus until we fix the speed straight sql is way faster anyway)
Created attachment 77143 [details] [review] Bug 8628: [FOLLOW-UP] More fixes This patch fixes qa tool issues, problems in comment 13, merge conflicts, other issues with patches Same test plan applies
Created attachment 77144 [details] [review] Bug 8628: [FOLLOW-UP] Add digital signs to the OPAC This patch rewrites all modules from the original patch to be object oriented. Follows above test plan. Sponsored-by: Region Halland
Created attachment 77145 [details] [review] Bug 8628: [FOLLOW-UP] Fixing internal server error and rebase issues This patch addresses the comments in Comment 23 Test that 1) all qa test tools pass 2) datatable on tools/signs.pl is not broken 3) features uses report group "SIGN" instead of "SIG" 4) you can complete the main test plan (no server errors)
Tested in Biblibre Sandbox 1 -- Digital signs does not appear under Tools/Additional Tools. cgi-bin/koha/opac-signs.pl not found on server. OPACDigitalSigns system preference is added.
Created attachment 78709 [details] Screenshot of the test. When creating a stream, I was not forced to NAME the stream, meaning it was unavailable to select for the sign. The test plan did not call for naming the stream. I have also attached a screen shot showing the following results: Images, local or otherwise, do now show. The listed titles below seem to be both showing up at the same time.
(In reply to Spencer from comment #36) Thanks for testing this Spencer! If the patches do not work as they should, you can change the status to "Failed QA" (and save some kittens)
Created attachment 80248 [details] [review] Bug 8628: [FOLLOW-UP] More fixes This patch fixes qa tool issues, problems in comment 13, merge conflicts, other issues with patches Same test plan applies
Created attachment 80249 [details] [review] Bug 8628: [FOLLOW-UP] Add digital signs to the OPAC This patch rewrites all modules from the original patch to be object oriented. Follows above test plan. Sponsored-by: Region Halland
Created attachment 80250 [details] [review] Bug 8628: [FOLLOW-UP] Fixing internal server error and rebase issues This patch addresses the comments in Comment 23 Test that 1) all qa test tools pass 2) datatable on tools/signs.pl is not broken 3) features uses report group "SIGN" instead of "SIG" 4) you can complete the main test plan (no server errors)
Created attachment 80252 [details] [review] Bug 8628: (follow-up) Some template fixes This patch: - makes the stream name a required field - fixes the link to the OPAC sign view - fixes the toolbar in staff side Still have not fixed the overlapping of titles.
Created attachment 82896 [details] [review] Bug 8628: Add digital signs to the OPAC, dbchanges Database changes for bug 8628 Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Created attachment 82897 [details] [review] Bug 8628: Add digital signs to the OPAC See http://wiki.koha-community.org/wiki/Digital_signs_RFC for details. To test: 1. Apply this patch and the database updates patch 2. Run updatedatabase.pl 3. In staff client, go to Tools/Additional Tools/Digital signs 4. You should be warned about OPACDigitalSigns not being enabled, you can ignore this for now. 5. Add a new sign by clicking the "+ New sign" button 6. Enter a name and optionally numbers for automatic page turing 7. Your new sign should appear in the Signs list 8. Add a new stream by clicking the "+ New stream" button 9. Unless you already have reports in the report group with code SIG, you should be warned that there are no reports in the group with code SIG and given a link for creating a new report. Follow the link and create a new report with report group code SIG. En example SQL command for the report could be: SELECT * FROM biblio WHERE timestamp > DATE_SUB(NOW(), INTERVAL 7 DAY) 10. Go back to the "new stream" page, and reload. You should no longer see a warning message, and your newly created report should appear in the list of reports. 11. Select the report and click Submit. Your newly created stream should now appear in the list of streams. 12. In the list of signs, press "edit streams" for the sign you previously created. 13. Choose a stream to attach and click Submit. Your sign is now ready for OPAC. 14. In OPAC, visit /cgi-bin/koha/opac-signs.pl 15. You should be told that Digital signs are not enabled. Enable with new system preference OPACDigitalSigns and reload the page. 15. You should see a list of available signs, click on a sign that you wish to display. 16. You should now see a list of all books matching the SQL query in the report that you attached to your stream. 17. If you have OPACLocalCoverImages enabled, all books with local covers attached should be presented using this cover. If no local cover is available and the book has a ISBN with a cover in openlibrary.org, the cover image from openlibrary.org should be shown. If all of the above fails, a cover matching the theme of the page should be seen, showing the book title and author. 18. Clicking a book should bring you to a detailed view of the book where you can see the books availability. You should also see the two next books and the two previous books in the stream (unless you're at the beginning or end of the stream) 19. Swiping (if no touch screen, click and hold left mouse button and drag) left/right should bring you to next/previous book. Clicking on the next/previous books (right/left of the active one) should bring you to the detailed view of the clicked book. 20. Leaving the page idle (i.e no user interaction) for the amount of time specified in step 6. should result in the page automatically switching to the next book in the stream. Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> In theory this could/should be rewritten to use Koha::Schema instead of direct sql, but this predates the switch, so would be unfair to reject it on that basis (plus until we fix the speed straight sql is way faster anyway)
Created attachment 82898 [details] [review] Bug 8628: (follow-up) More fixes This patch fixes qa tool issues, problems in comment 13, merge conflicts, other issues with patches Same test plan applies
Created attachment 82899 [details] [review] Bug 8628: (follow-up) Add digital signs to the OPAC This patch rewrites all modules from the original patch to be object oriented. Follows above test plan. Sponsored-by: Region Halland
Created attachment 82900 [details] [review] Bug 8628: (follow-up) Fixing internal server error and rebase issues This patch addresses the comments in Comment 23 Test that 1) all qa test tools pass 2) datatable on tools/signs.pl is not broken 3) features uses report group "SIGN" instead of "SIG" 4) you can complete the main test plan (no server errors)
Created attachment 82901 [details] [review] Bug 8628: (follow-up) Some template fixes This patch: - makes the stream name a required field - fixes the link to the OPAC sign view - fixes the toolbar in staff side Still have not fixed the overlapping of titles.
Created attachment 83312 [details] [review] Bug 8628: (follow-up) Fixing CSS so titles don't overlap I have amended the CSS so the titles sit side-by-side rather than on top of each other.
Please rebase on master.
Created attachment 88821 [details] [review] Bug 8628: Digital signs - db changes - Adding edit_digital_signs permission for managing digital signs - Adding OPACDigitalSigns, OPACDigitalSignsCSS and OPACDigitalSignsSwatches system preferences - Adding signs, sign_streams and signs_to_streams tables - Updating sysprefs.sql and kohastructure.sql
Created attachment 88822 [details] [review] Bug 8628: Digital signs - schema updates
Created attachment 88823 [details] [review] Bug 8628: Digital signs - Koha objects
Created attachment 88824 [details] [review] Bug 8628: Digital signs - preferences and permissions
Created attachment 88825 [details] [review] Bug 8628: Digital signs - staff interface This patch adds the interface for creating and managing digital signs and streams.
Created attachment 88826 [details] [review] Bug 8628: Digital signs - opac interface To test: 1. Apply this patch and the database updates patch 2. Run updatedatabase.pl 3. In staff client, go to Tools/Additional Tools/Digital signs 4. You should be warned about OPACDigitalSigns not being enabled, you can ignore this for now. 5. Add a new sign by clicking the "+ New sign" button 6. Enter a name and optionally numbers for automatic page turing 7. Your new sign should appear in the Signs list 8. Add a new stream by clicking the "+ New stream" button 9. Unless you already have reports in the report group with code SIGN, you should be warned that there are no reports in the group with code SIGN and given a link for creating a new report. Follow the link and create a new report with report group code SIGN. En example SQL command for the report could be: SELECT * FROM biblio WHERE timestamp > DATE_SUB(NOW(), INTERVAL 7 DAY) or if you are testing the parameters feature of the digital signs, an example report could be: SELECT * FROM biblio WHERE biblionumber < placeholder. 10. Go back to the "new stream" page, and reload. You should no longer see a warning message, and your newly created report should appear in the list of reports. 11. Select the report and click Submit. Your newly created stream should now appear in the list of streams. 12. In the list of signs, press "edit streams" for the sign you previously created. 13. Choose a stream to attach and click Submit. If you have attached a report with a parameter placeholder, edit the parameters so that the placeholder gets substituted with a value. For example, in the edit parameters box, you can have: placeholder = 10000 When you submit, you'll see the SQL replaces the placeholder with your value and completes the query. Your sign is now ready for OPAC. 14. In OPAC, visit /cgi-bin/koha/opac-signs.pl 15. You should be told that Digital signs are not enabled. Enable with new system preference OPACDigitalSigns and reload the page. 15. You should see a list of available signs, click on a sign that you wish to display. 16. You should now see a list of all books matching the SQL query in the report that you attached to your stream. 17. If you have OPACLocalCoverImages enabled, all books with local covers attached should be presented using this cover. If no local cover is available and the book has a ISBN with a cover in openlibrary.org, the cover image from openlibrary.org should be shown. If all of the above fails, a cover matching the theme of the page should be seen, showing the book title and author. 18. Clicking a book should bring you to a detailed view of the book where you can see the books availability. You should also see the two next books and the two previous books in the stream (unless you're at the beginning or end of the stream) 19. Swiping (if no touch screen, click and hold left mouse button and drag) left/right should bring you to next/previous book. Clicking on the next/previous books (right/left of the active one) should bring you to the detailed view of the clicked book. 20. Leaving the page idle (i.e no user interaction) for the amount of time specified in step 6. should result in the page automatically switching to the next book in the stream. Sponsored-by: Regionbibliotek Halland / County library of Halland
Created attachment 93054 [details] [review] Bug 8628: Digital signs - db changes - Adding edit_digital_signs permission for managing digital signs - Adding OPACDigitalSigns, OPACDigitalSignsCSS and OPACDigitalSignsSwatches system preferences - Adding signs, sign_streams and signs_to_streams tables - Updating sysprefs.sql and kohastructure.sql
Created attachment 93055 [details] [review] Bug 8628: Digital signs - schema updates
Created attachment 93056 [details] [review] Bug 8628: Digital signs - Koha objects
Created attachment 93057 [details] [review] Bug 8628: Digital signs - preferences and permissions
Created attachment 93058 [details] [review] Bug 8628: Digital signs - staff interface This patch adds the interface for creating and managing digital signs and streams.
Created attachment 93059 [details] [review] Bug 8628: Digital signs - opac interface To test: 1. Apply this patch and the database updates patch 2. Run updatedatabase.pl 3. In staff client, go to Tools/Additional Tools/Digital signs 4. You should be warned about OPACDigitalSigns not being enabled, you can ignore this for now. 5. Add a new sign by clicking the "+ New sign" button 6. Enter a name and optionally numbers for automatic page turing 7. Your new sign should appear in the Signs list 8. Add a new stream by clicking the "+ New stream" button 9. Unless you already have reports in the report group with code SIGN, you should be warned that there are no reports in the group with code SIGN and given a link for creating a new report. Follow the link and create a new report with report group code SIGN. En example SQL command for the report could be: SELECT * FROM biblio WHERE timestamp > DATE_SUB(NOW(), INTERVAL 7 DAY) or if you are testing the parameters feature of the digital signs, an example report could be: SELECT * FROM biblio WHERE biblionumber < placeholder. 10. Go back to the "new stream" page, and reload. You should no longer see a warning message, and your newly created report should appear in the list of reports. 11. Select the report and click Submit. Your newly created stream should now appear in the list of streams. 12. In the list of signs, press "edit streams" for the sign you previously created. 13. Choose a stream to attach and click Submit. If you have attached a report with a parameter placeholder, edit the parameters so that the placeholder gets substituted with a value. For example, in the edit parameters box, you can have: placeholder = 10000 When you submit, you'll see the SQL replaces the placeholder with your value and completes the query. Your sign is now ready for OPAC. 14. In OPAC, visit /cgi-bin/koha/opac-signs.pl 15. You should be told that Digital signs are not enabled. Enable with new system preference OPACDigitalSigns and reload the page. 15. You should see a list of available signs, click on a sign that you wish to display. 16. You should now see a list of all books matching the SQL query in the report that you attached to your stream. 17. If you have OPACLocalCoverImages enabled, all books with local covers attached should be presented using this cover. If no local cover is available and the book has a ISBN with a cover in openlibrary.org, the cover image from openlibrary.org should be shown. If all of the above fails, a cover matching the theme of the page should be seen, showing the book title and author. 18. Clicking a book should bring you to a detailed view of the book where you can see the books availability. You should also see the two next books and the two previous books in the stream (unless you're at the beginning or end of the stream) 19. Swiping (if no touch screen, click and hold left mouse button and drag) left/right should bring you to next/previous book. Clicking on the next/previous books (right/left of the active one) should bring you to the detailed view of the clicked book. 20. Leaving the page idle (i.e no user interaction) for the amount of time specified in step 6. should result in the page automatically switching to the next book in the stream. Sponsored-by: Regionbibliotek Halland / County library of Halland
Minor rebase on kohastructure
Created attachment 93066 [details] [review] Bug 8628: Digital signs - db changes - Adding edit_digital_signs permission for managing digital signs - Adding OPACDigitalSigns, OPACDigitalSignsCSS and OPACDigitalSignsSwatches system preferences - Adding signs, sign_streams and signs_to_streams tables - Updating sysprefs.sql and kohastructure.sql Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
Created attachment 93067 [details] [review] Bug 8628: Digital signs - schema updates Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
Created attachment 93068 [details] [review] Bug 8628: Digital signs - Koha objects Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
Created attachment 93069 [details] [review] Bug 8628: Digital signs - preferences and permissions Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
Created attachment 93070 [details] [review] Bug 8628: Digital signs - staff interface This patch adds the interface for creating and managing digital signs and streams. Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
Created attachment 93071 [details] [review] Bug 8628: Digital signs - opac interface To test: 1. Apply this patch and the database updates patch 2. Run updatedatabase.pl 3. In staff client, go to Tools/Additional Tools/Digital signs 4. You should be warned about OPACDigitalSigns not being enabled, you can ignore this for now. 5. Add a new sign by clicking the "+ New sign" button 6. Enter a name and optionally numbers for automatic page turing 7. Your new sign should appear in the Signs list 8. Add a new stream by clicking the "+ New stream" button 9. Unless you already have reports in the report group with code SIGN, you should be warned that there are no reports in the group with code SIGN and given a link for creating a new report. Follow the link and create a new report with report group code SIGN. En example SQL command for the report could be: SELECT * FROM biblio WHERE timestamp > DATE_SUB(NOW(), INTERVAL 7 DAY) or if you are testing the parameters feature of the digital signs, an example report could be: SELECT * FROM biblio WHERE biblionumber < placeholder. 10. Go back to the "new stream" page, and reload. You should no longer see a warning message, and your newly created report should appear in the list of reports. 11. Select the report and click Submit. Your newly created stream should now appear in the list of streams. 12. In the list of signs, press "edit streams" for the sign you previously created. 13. Choose a stream to attach and click Submit. If you have attached a report with a parameter placeholder, edit the parameters so that the placeholder gets substituted with a value. For example, in the edit parameters box, you can have: placeholder = 10000 When you submit, you'll see the SQL replaces the placeholder with your value and completes the query. Your sign is now ready for OPAC. 14. In OPAC, visit /cgi-bin/koha/opac-signs.pl 15. You should be told that Digital signs are not enabled. Enable with new system preference OPACDigitalSigns and reload the page. 15. You should see a list of available signs, click on a sign that you wish to display. 16. You should now see a list of all books matching the SQL query in the report that you attached to your stream. 17. If you have OPACLocalCoverImages enabled, all books with local covers attached should be presented using this cover. If no local cover is available and the book has a ISBN with a cover in openlibrary.org, the cover image from openlibrary.org should be shown. If all of the above fails, a cover matching the theme of the page should be seen, showing the book title and author. 18. Clicking a book should bring you to a detailed view of the book where you can see the books availability. You should also see the two next books and the two previous books in the stream (unless you're at the beginning or end of the stream) 19. Swiping (if no touch screen, click and hold left mouse button and drag) left/right should bring you to next/previous book. Clicking on the next/previous books (right/left of the active one) should bring you to the detailed view of the clicked book. 20. Leaving the page idle (i.e no user interaction) for the amount of time specified in step 6. should result in the page automatically switching to the next book in the stream. Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
Hi Aleisha, this no longer applies, can you please rebase and run QA tools on the set? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 8628: Digital signs - db changes Using index info to reconstruct a base tree... M installer/data/mysql/kohastructure.sql M installer/data/mysql/sysprefs.sql Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql error: Failed to merge in the changes. Patch failed at 0001 Bug 8628: Digital signs - db changes Use 'git am --show-current-patch' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-8628-Digital-signs---db-changes-T0d215.patch
Created attachment 99608 [details] [review] Bug 8628: Digital signs - db changes - Adding edit_digital_signs permission for managing digital signs - Adding OPACDigitalSigns, OPACDigitalSignsCSS and OPACDigitalSignsSwatches system preferences - Adding signs, sign_streams and signs_to_streams tables - Updating sysprefs.sql and kohastructure.sql Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
Created attachment 99609 [details] [review] Bug 8628: Digital signs - schema updates Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
Created attachment 99610 [details] [review] Bug 8628: Digital signs - Koha objects Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
Created attachment 99611 [details] [review] Bug 8628: Digital signs - preferences and permissions Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
Created attachment 99612 [details] [review] Bug 8628: Digital signs - staff interface This patch adds the interface for creating and managing digital signs and streams. Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
Created attachment 99613 [details] [review] Bug 8628: Digital signs - opac interface To test: 1. Apply this patch and the database updates patch 2. Run updatedatabase.pl 3. In staff client, go to Tools/Additional Tools/Digital signs 4. You should be warned about OPACDigitalSigns not being enabled, you can ignore this for now. 5. Add a new sign by clicking the "+ New sign" button 6. Enter a name and optionally numbers for automatic page turing 7. Your new sign should appear in the Signs list 8. Add a new stream by clicking the "+ New stream" button 9. Unless you already have reports in the report group with code SIGN, you should be warned that there are no reports in the group with code SIGN and given a link for creating a new report. Follow the link and create a new report with report group code SIGN. En example SQL command for the report could be: SELECT * FROM biblio WHERE timestamp > DATE_SUB(NOW(), INTERVAL 7 DAY) or if you are testing the parameters feature of the digital signs, an example report could be: SELECT * FROM biblio WHERE biblionumber < placeholder. 10. Go back to the "new stream" page, and reload. You should no longer see a warning message, and your newly created report should appear in the list of reports. 11. Select the report and click Submit. Your newly created stream should now appear in the list of streams. 12. In the list of signs, press "edit streams" for the sign you previously created. 13. Choose a stream to attach and click Submit. If you have attached a report with a parameter placeholder, edit the parameters so that the placeholder gets substituted with a value. For example, in the edit parameters box, you can have: placeholder = 10000 When you submit, you'll see the SQL replaces the placeholder with your value and completes the query. Your sign is now ready for OPAC. 14. In OPAC, visit /cgi-bin/koha/opac-signs.pl 15. You should be told that Digital signs are not enabled. Enable with new system preference OPACDigitalSigns and reload the page. 15. You should see a list of available signs, click on a sign that you wish to display. 16. You should now see a list of all books matching the SQL query in the report that you attached to your stream. 17. If you have OPACLocalCoverImages enabled, all books with local covers attached should be presented using this cover. If no local cover is available and the book has a ISBN with a cover in openlibrary.org, the cover image from openlibrary.org should be shown. If all of the above fails, a cover matching the theme of the page should be seen, showing the book title and author. 18. Clicking a book should bring you to a detailed view of the book where you can see the books availability. You should also see the two next books and the two previous books in the stream (unless you're at the beginning or end of the stream) 19. Swiping (if no touch screen, click and hold left mouse button and drag) left/right should bring you to next/previous book. Clicking on the next/previous books (right/left of the active one) should bring you to the detailed view of the clicked book. 20. Leaving the page idle (i.e no user interaction) for the amount of time specified in step 6. should result in the page automatically switching to the next book in the stream. Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
Created attachment 99614 [details] [review] Bug 8628: (follow-up) Use utf8mb4 and TableExists in atomic update
Created attachment 99615 [details] [review] Bug 8628: (follow-up) Fixing 'UseKohaPlugins' for qa tools
Created attachment 99616 [details] [review] Bug 8628: (follow-up) Fixes for qa tools using Asset and Koha.Preference
Created attachment 99617 [details] [review] Bug 8628: Digital signs - db changes - Adding edit_digital_signs permission for managing digital signs - Adding OPACDigitalSigns, OPACDigitalSignsCSS and OPACDigitalSignsSwatches system preferences - Adding signs, sign_streams and signs_to_streams tables - Updating sysprefs.sql and kohastructure.sql Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
Created attachment 99618 [details] [review] Bug 8628: Digital signs - schema updates Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
Created attachment 99619 [details] [review] Bug 8628: Digital signs - Koha objects Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
Created attachment 99620 [details] [review] Bug 8628: Digital signs - preferences and permissions Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
Created attachment 99621 [details] [review] Bug 8628: Digital signs - staff interface This patch adds the interface for creating and managing digital signs and streams. Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
Created attachment 99622 [details] [review] Bug 8628: Digital signs - opac interface To test: 1. Apply this patch and the database updates patch 2. Run updatedatabase.pl 3. In staff client, go to Tools/Additional Tools/Digital signs 4. You should be warned about OPACDigitalSigns not being enabled, you can ignore this for now. 5. Add a new sign by clicking the "+ New sign" button 6. Enter a name and optionally numbers for automatic page turing 7. Your new sign should appear in the Signs list 8. Add a new stream by clicking the "+ New stream" button 9. Unless you already have reports in the report group with code SIGN, you should be warned that there are no reports in the group with code SIGN and given a link for creating a new report. Follow the link and create a new report with report group code SIGN. En example SQL command for the report could be: SELECT * FROM biblio WHERE timestamp > DATE_SUB(NOW(), INTERVAL 7 DAY) or if you are testing the parameters feature of the digital signs, an example report could be: SELECT * FROM biblio WHERE biblionumber < placeholder. 10. Go back to the "new stream" page, and reload. You should no longer see a warning message, and your newly created report should appear in the list of reports. 11. Select the report and click Submit. Your newly created stream should now appear in the list of streams. 12. In the list of signs, press "edit streams" for the sign you previously created. 13. Choose a stream to attach and click Submit. If you have attached a report with a parameter placeholder, edit the parameters so that the placeholder gets substituted with a value. For example, in the edit parameters box, you can have: placeholder = 10000 When you submit, you'll see the SQL replaces the placeholder with your value and completes the query. Your sign is now ready for OPAC. 14. In OPAC, visit /cgi-bin/koha/opac-signs.pl 15. You should be told that Digital signs are not enabled. Enable with new system preference OPACDigitalSigns and reload the page. 15. You should see a list of available signs, click on a sign that you wish to display. 16. You should now see a list of all books matching the SQL query in the report that you attached to your stream. 17. If you have OPACLocalCoverImages enabled, all books with local covers attached should be presented using this cover. If no local cover is available and the book has a ISBN with a cover in openlibrary.org, the cover image from openlibrary.org should be shown. If all of the above fails, a cover matching the theme of the page should be seen, showing the book title and author. 18. Clicking a book should bring you to a detailed view of the book where you can see the books availability. You should also see the two next books and the two previous books in the stream (unless you're at the beginning or end of the stream) 19. Swiping (if no touch screen, click and hold left mouse button and drag) left/right should bring you to next/previous book. Clicking on the next/previous books (right/left of the active one) should bring you to the detailed view of the clicked book. 20. Leaving the page idle (i.e no user interaction) for the amount of time specified in step 6. should result in the page automatically switching to the next book in the stream. Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com>
Created attachment 99623 [details] [review] Bug 8628: (follow-up) Use utf8mb4 and TableExists in atomic update
Created attachment 99624 [details] [review] Bug 8628: (follow-up) Fixes for qa tools using Asset and Koha.Preference
Sorry for all the attachments! Ready to test
I'm getting this error: Template process failed: undef error - DBIC result _type isn't of the _type SavedSql at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt line 419. at /kohadevbox/koha/C4/Templates.pm line 122 Did I miss a step in the setup?
(In reply to Owen Leonard from comment #88) > I'm getting this error: > > Template process failed: undef error - DBIC result _type isn't of the _type > SavedSql at > /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt line > 419. > at /kohadevbox/koha/C4/Templates.pm line 122 > > > Did I miss a step in the setup? Hi Owen You may need to update the schema files and restart memcached because of the db changes
I'm getting an error when running the database update: DEV atomic update: bug_8628-digital-signs-permissions.perl Upgrade to XXX done (Bug 8628 - adding permission for managing digital signs) DEV atomic update: bug_8628-digital-signs-sysprefs.perl Upgrade to XXX done (Bug 8628 - Adding OPACDigitalSigns, OPACDigitalSignsCSS and OPACDigitalSignsSwatches system preferences) DEV atomic update: bug_8628-digital-signs.perl DBD::mysql::db do failed: Unknown collation: 'utf8mb4' [for Statement " CREATE TABLE sign_streams ( sign_stream_id int(11) NOT NULL auto_increment, -- primary key, used to identify streams saved_sql_id int(11) NOT NULL, -- foreign key from the saved_sql table name varchar(64), -- name/title of the sign PRIMARY KEY (sign_stream_id), CONSTRAINT sign_streams_ibfk_1 FOREIGN KEY (saved_sql_id) REFERENCES saved_sql (id) ON DELETE CASCADE ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4 "] at (eval 1419) line 6. DBD::mysql::db do failed: Can't create table 'koha_kohadev.signs_to_streams' (errno: 150) [for Statement " CREATE TABLE signs_to_streams ( sign_to_stream_id int(11) NOT NULL auto_increment, -- primary key, used to identify connections between signs and streams (the same stream can be attached to a sign more than once, with different parameters) sign_stream_id int(11) NOT NULL, -- foreign key from the decks sign_streams table sign_id int(11) NOT NULL, -- foreign key from the signs table params varchar(255) NOT NULL DEFAULT '', -- list of parameters for the SQL associated with the sign_stream PRIMARY KEY (sign_to_stream_id), CONSTRAINT signs_to_streams_ibfk_1 FOREIGN KEY (sign_stream_id) REFERENCES sign_streams (sign_stream_id) ON DELETE CASCADE, CONSTRAINT signs_to_streams_ibfk_2 FOREIGN KEY (sign_id) REFERENCES signs (sign_id) ON DELETE CASCADE ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci "] at (eval 1419) line 34. Upgrade to XXX done (Bug 8628 - add signs, sign_streams and signs_to_streams tables)
Created attachment 99717 [details] [review] Bug 8628: (follow-up) Use utf8mb4 and TableExists in atomic update
Created attachment 99718 [details] [review] Bug 8628: (follow-up) Fixes for qa tools using Asset and Koha.Preference
(In reply to David Nind from comment #90) > I'm getting an error when running the database update: oops! this should be fixed now
Created attachment 99801 [details] Screenshots - screens not aligned correctly It may be my setup (using koha-testing-docker) but I can't seem to get the staff interface screens and the signage to display correctly (Firefox, Google Chrome, and Chromium on Ubuntu 18.04). In the staff interface the add and edit screens take up the whole width of the screen, and the other tools menu items are pushed to the bottom. On the signage screens, things don't display correctly. Screenshots attached. Notes from testing : - Apply patches - Run updatedatabase - Run dbic - flush_memcached - restart_all
(In reply to David Nind from comment #94) > > In the staff interface the add and edit screens take up the whole width of > the screen, and the other tools menu items are pushed to the bottom. Will look into this > > On the signage screens, things don't display correctly. Can you please advise what 'correctly' should look like? I took this patch over from someone else and the signs have always displayed for me the way they do in your screenshots. How do you expect them to look?
I'm not sure what 'correct' should look like, and was going off the original mockups at https://wiki.koha-community.org/wiki/Digital_signs_RFC I guess I was expecting the covers (if they exist) to display. When you click (or touch on a touch screen) an item it will pop up with the details. You can then continue paging through.