Use this bug when testing your git-bz. :) DO YOUR WORST!! (yes, that's a challenge)
Created attachment 4386 [details] [review] [SIGNED OFF] Bug 6467: Add shelving location to checkin screen
Comment on attachment 4386 [details] [review] [SIGNED OFF] Bug 6467: Add shelving location to checkin screen Testing
Created attachment 6837 [details] [review] Bug 6473 - testing obsoleting of attachments from gitbz
Created attachment 6838 [details] [review] Bug 6473 - testing obsoleting of attachments from gitbz
Created attachment 6839 [details] [review] Bug 6473 - an edit to the file
Created attachment 6840 [details] [review] Bug 6473 - an edit to the file Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 6841 [details] [review] Bug 6473 - an edit to the file Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 6842 [details] [review] Bug 6473 - an edit to the file Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 6843 [details] [review] Bug 6473 - an edit to the file Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 7154 [details] [review] Test patch. Ignore
Created attachment 7155 [details] [review] Bug 1633 - Interface revisions for the staff client This patch revises the image viewer page to match other biblio detail pages: a toolbar, a sidebar menu, etc. Additional data is now pulled by imageviewer.pl in order to provide information necessary for the proper functioning of the toolbar and menus: item counts, hold availability, biblio view options. Other changes have been made to match the changes in the OPAC interface like styling of the images and no-javascript compatibility Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Magnus Enger <magnus@enger.priv.no> Patch failed to apply because of multiple Content-Type lines in the patch. Corrected the same with this new patch.
Created attachment 7567 [details] [review] this patch does not apply, it's just to do some testing for a new script that automatically detects all patches that does not apply
Created attachment 7994 [details] [review] bug 5503 follow-up DBrev number + added "upgrade to $DBversion" string
Created attachment 7995 [details] [review] Bug 7582 - When adding a Z39.50 server the "checked" option should use a checkbox Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Created attachment 7996 [details] [review] Bug 7582 - When adding a Z39.50 server the "checked" option should use a checkbox Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Created attachment 7997 [details] [review] bug 5503 follow-up DBrev number + added "upgrade to $DBversion" string
testing emails
Created attachment 8018 [details] [review] [Signed Off] Bug 7633 - Move display of patron image in self checkout This patch moves the display of the patron image in self-checkout from above the checkout form into a column to the right of the form. The patch also corrects an error in the display of the page title which was preventing correct display of the library name. To test this change confirm that the page title shows the value of your LibraryName system preference or "Koha" if the preference is empty. http://bugs.koha-community.org/show_bug.cgi?id=7631 Signed-off-by: Liz Rea <wizzyrea@gmail.com> Confirmed working as expected. Passes template tests. Signed-off-by: Liz Rea <wizzyrea@gmail.com> another test
Created attachment 9807 [details] [review] Bug 6473 testing git bz This patch does nothing interesting and is used for testing git bz
Created attachment 9808 [details] [review] Bug 6473 testing git bz This patch does nothing interesting and is used for testing git bz Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Patch tested with a sandbox, by Paul Poulain that has not this mail <paul.poulain@free.fr>
Created attachment 9813 [details] [review] Bug 6473 testing git bz This patch does nothing interesting and is used for testing git bz Signed-off-by: Paul Poulain that has not this mail <paul.poulain@free.fr>
Patch tested with a sandbox, by Paul Poulain testing sandboxes <paul.poulain@free.fr>
Created attachment 9831 [details] [review] Bug 6473 testing git bz This patch does nothing interesting and is used for testing git bz Signed-off-by: Paul Poulain testing sandboxes <paul.poulain@free.fr>
Created attachment 9832 [details] [review] Bug 6473 testing git bz This patch does nothing interesting and is used for testing git bz Signed-off-by: Paul Poulain testing sandboxes <paul.poulain@free.fr>
Patch tested with a sandbox, by `id` <test@test>
Created attachment 9836 [details] [review] Bug 6473 testing git bz This patch does nothing interesting and is used for testing git bz Signed-off-by: Paul Poulain testing sandboxes <paul.poulain@free.fr> Signed-off-by: uid=1016(koha) gid=1022(koha) groupes=1022(koha),5(tty) <test@test>
Patch tested with a sandbox, by Paul Poulain testing a new patch <paul.poulain@biblibre.com>
Created attachment 9854 [details] [review] Bug 4330 : Adding copyright headers and fixing FSF addresses Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Paul Poulain testing a new patch <paul.poulain@biblibre.com>
Patch tested with a sandbox, by Paul Poulain that has not this mail id <id>
Created attachment 10842 [details] [review] Bug 8353 follow-up adding a tiny sh in misc/maintenance This script will help the sysadmin know there's a test he can use during maintenance Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Status: Needs Signoff
Created attachment 10843 [details] [review] Bug 8353 follow-up adding a tiny sh in misc/maintenance This script will help the sysadmin know there's a test he can use during maintenance Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 10844 [details] [review] Bug 8353 follow-up adding a tiny sh in misc/maintenance This script will help the sysadmin know there's a test he can use during maintenance Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 10845 [details] [review] Bug 8353 follow-up adding a tiny sh in misc/maintenance This script will help the sysadmin know there's a test he can use during maintenance Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 10846 [details] [review] Bug 8353 follow-up adding a tiny sh in misc/maintenance This script will help the sysadmin know there's a test he can use during maintenance Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 10847 [details] [review] Bug 8353 follow-up adding a tiny sh in misc/maintenance This script will help the sysadmin know there's a test he can use during maintenance Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 10848 [details] [review] Bug 8353 follow-up adding a tiny sh in misc/maintenance This script will help the sysadmin know there's a test he can use during maintenance Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 10849 [details] [review] Bug 8353 follow-up adding a tiny sh in misc/maintenance This script will help the sysadmin know there's a test he can use during maintenance Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 10850 [details] [review] Bug 8353 follow-up adding a tiny sh in misc/maintenance This script will help the sysadmin know there's a test he can use during maintenance Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 10851 [details] [review] Bug 8353 follow-up adding a tiny sh in misc/maintenance This script will help the sysadmin know there's a test he can use during maintenance Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 10852 [details] [review] Bug 8353 follow-up adding a tiny sh in misc/maintenance This script will help the sysadmin know there's a test he can use during maintenance Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 10853 [details] [review] Bug 8353 follow-up adding a tiny sh in misc/maintenance This script will help the sysadmin know there's a test he can use during maintenance Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 10854 [details] [review] Bug 8353 follow-up adding a tiny sh in misc/maintenance This script will help the sysadmin know there's a test he can use during maintenance Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 10855 [details] [review] Bug 8353 follow-up adding a tiny sh in misc/maintenance This script will help the sysadmin know there's a test he can use during maintenance Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 10856 [details] [review] Bug 8353 follow-up adding a tiny sh in misc/maintenance This script will help the sysadmin know there's a test he can use during maintenance Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 10857 [details] [review] Bug 8353 follow-up adding a tiny sh in misc/maintenance This script will help the sysadmin know there's a test he can use during maintenance Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 10858 [details] [review] Bug 8353 follow-up adding a tiny sh in misc/maintenance This script will help the sysadmin know there's a test he can use during maintenance Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 11540 [details] [review] adding file b
Created attachment 11543 [details] [review] adding file a
Created attachment 11544 [details] [review] adding file b
Created attachment 12502 [details] [review] modified: git-bz
Created attachment 12513 [details] [review] git bz test
Created attachment 12514 [details] [review] git bz test
Created attachment 12515 [details] [review] git bz test
Created attachment 12516 [details] [review] git bz test
Created attachment 12517 [details] [review] git bz test
Created attachment 12518 [details] [review] git bz test
Created attachment 12519 [details] [review] git bz test
test
Created attachment 13473 [details] [review] Bug 9066: VirtualShelves db access not Plack+MariaDB compatible The $dbh database handle in C4::VirtualShelves was declared at the module level, which means under Plack it is initialized only once, when the server first starts. With the default MySQL configuration this is not a problem, since the MySQL connection does not time out, but the MariaDB default configuration does time out, resulting in every page that calls any sub in C4::VirtualShelves failing after a certain period. This patch eliminates the module-level $dbh variable and replaces it with $dbh handles in each subroutine that requires it. To test: Confirm that Virtual Shelves functionality still works as expected. The problem is not reproducible when using Apache or Plack+MySQL, but if everything works after the patch has been applied, the changes are safe.
(In reply to comment #62) > Created attachment 13473 [details] [review] > Bug 9066: VirtualShelves db access not Plack+MariaDB compatible Is this patch on the right bug, Mason?
(testing patch complexity custom field)
Created attachment 13673 [details] [review] test test
Created attachment 14955 [details] [review] 9105: Followup for closing Zoom connections Housekeeping: close the results sets and connections from Z3950 searches. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 14969 [details] [review] 9088: Default values for fund and item type on neworderempty form (dbrev) Adds pref to database for install and upgrade. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 14970 [details] [review] 9088: Default values for fund and item type on neworderempty form (dbrev) Adds pref to database for install and upgrade. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> http://bugs.koha-community.org/show_bug.cgi?id=6473 Passed-QA-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 14972 [details] [review] 9088: Default values for fund and item type on neworderempty form (dbrev) Adds pref to database for install and upgrade. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> http://bugs.koha-community.org/show_bug.cgi?id=6473 Passed-QA-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Passed-QA-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Passed-QA-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Passed-QA-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Passed-QA-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 15201 [details] [review] test
Comment on attachment 15201 [details] [review] test Review of attachment 15201 [details] [review]: ----------------------------------------------------------------- This change looks ok to me, blah blah test test
Comment on attachment 15201 [details] [review] test Review of attachment 15201 [details] [review]: ----------------------------------------------------------------- Marked as verified
Created attachment 18949 [details] [review] Bug 9755: Refactor record merge functionality This patch refactors the merge record interface and code a little bit in preparation for making it possible to merge authority records. To test: 1) Apply patch. 2) Try merging two records: a) Create a list. b) Add two records you would like to (or be willing to) merge to said list. c) View said list. d) Check the checkboxes next to the two records you added. e) Click "Merge selected records." f) Choose a merge reference. g) Choose fields from each record that you want to keep. h) Click "Merge." 3) Confirm that your merged record has the fields and subfields you wanted. 4) Run the unit tests for the two files that were changed: prove t/Koha_Record.t t/db_dependent/Koha_Authority.t 5) Sign off. Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Filtered Filtered 04156f6cee8db3b11f71fb84eb0d6868956050db Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 18950 [details] [review] Bug 9755 QA follow-up: move MARC-specific functionality to utility class This follow-up moves all the MARC-specific functionality of Koha::Record (now renamed to Koha::MetadataRecord) to a Koha::Util::MARC utility class. To test, run relevant unit tests: > prove t/Koha_MetadataRecord.t t/Koha_Util_MARC.t t/db_dependent/Koha_Authority.t and optionally try to merge a record. Filtered Filtered f6b051d4b180ca8882626bd6adfc7bb98eb97550 Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 18951 [details] [review] Bug 9755 QA follow-up: move MARC-specific functionality to utility class This follow-up moves all the MARC-specific functionality of Koha::Record (now renamed to Koha::MetadataRecord) to a Koha::Util::MARC utility class. To test, run relevant unit tests: > prove t/Koha_MetadataRecord.t t/Koha_Util_MARC.t t/db_dependent/Koha_Authority.t and optionally try to merge a record. Filtered Filtered f6b051d4b180ca8882626bd6adfc7bb98eb97550 Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> http://bugs.koha-community.org/show_bug.cgi?id=6473 Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 18952 [details] [review] Bug 9755 QA follow-up: move MARC-specific functionality to utility class This follow-up moves all the MARC-specific functionality of Koha::Record (now renamed to Koha::MetadataRecord) to a Koha::Util::MARC utility class. To test, run relevant unit tests: > prove t/Koha_MetadataRecord.t t/Koha_Util_MARC.t t/db_dependent/Koha_Authority.t and optionally try to merge a record. Filtered Filtered f6b051d4b180ca8882626bd6adfc7bb98eb97550 Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> http://bugs.koha-community.org/show_bug.cgi?id=6473 Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 18953 [details] [review] Bug 9755 QA follow-up: move MARC-specific functionality to utility class This follow-up moves all the MARC-specific functionality of Koha::Record (now renamed to Koha::MetadataRecord) to a Koha::Util::MARC utility class. To test, run relevant unit tests: > prove t/Koha_MetadataRecord.t t/Koha_Util_MARC.t t/db_dependent/Koha_Authority.t and optionally try to merge a record. Filtered Filtered f6b051d4b180ca8882626bd6adfc7bb98eb97550 Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> http://bugs.koha-community.org/show_bug.cgi?id=6473 Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 18954 [details] [review] Bug 9755 QA follow-up: move MARC-specific functionality to utility class This follow-up moves all the MARC-specific functionality of Koha::Record (now renamed to Koha::MetadataRecord) to a Koha::Util::MARC utility class. To test, run relevant unit tests: > prove t/Koha_MetadataRecord.t t/Koha_Util_MARC.t t/db_dependent/Koha_Authority.t and optionally try to merge a record. Filtered Filtered f6b051d4b180ca8882626bd6adfc7bb98eb97550 Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> http://bugs.koha-community.org/show_bug.cgi?id=6473 Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 18955 [details] [review] Bug 9755 QA follow-up: move MARC-specific functionality to utility class This follow-up moves all the MARC-specific functionality of Koha::Record (now renamed to Koha::MetadataRecord) to a Koha::Util::MARC utility class. To test, run relevant unit tests: > prove t/Koha_MetadataRecord.t t/Koha_Util_MARC.t t/db_dependent/Koha_Authority.t and optionally try to merge a record. Filtered Filtered f6b051d4b180ca8882626bd6adfc7bb98eb97550 Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> http://bugs.koha-community.org/show_bug.cgi?id=6473 Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 18956 [details] [review] Bug 9755: Refactor record merge functionality This patch refactors the merge record interface and code a little bit in preparation for making it possible to merge authority records. To test: 1) Apply patch. 2) Try merging two records: a) Create a list. b) Add two records you would like to (or be willing to) merge to said list. c) View said list. d) Check the checkboxes next to the two records you added. e) Click "Merge selected records." f) Choose a merge reference. g) Choose fields from each record that you want to keep. h) Click "Merge." 3) Confirm that your merged record has the fields and subfields you wanted. 4) Run the unit tests for the two files that were changed: prove t/Koha_Record.t t/db_dependent/Koha_Authority.t 5) Sign off. Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Filtered Filtered 04156f6cee8db3b11f71fb84eb0d6868956050db Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> http://bugs.koha-community.org/show_bug.cgi?id=6473 Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 18957 [details] [review] Bug 9755 QA follow-up: move MARC-specific functionality to utility class This follow-up moves all the MARC-specific functionality of Koha::Record (now renamed to Koha::MetadataRecord) to a Koha::Util::MARC utility class. To test, run relevant unit tests: > prove t/Koha_MetadataRecord.t t/Koha_Util_MARC.t t/db_dependent/Koha_Authority.t and optionally try to merge a record. Filtered Filtered f6b051d4b180ca8882626bd6adfc7bb98eb97550 Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> http://bugs.koha-community.org/show_bug.cgi?id=6473 Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 18958 [details] [review] Bug 9755 QA follow-up: move MARC-specific functionality to utility class This follow-up moves all the MARC-specific functionality of Koha::Record (now renamed to Koha::MetadataRecord) to a Koha::Util::MARC utility class. To test, run relevant unit tests: > prove t/Koha_MetadataRecord.t t/Koha_Util_MARC.t t/db_dependent/Koha_Authority.t and optionally try to merge a record. Filtered Filtered f6b051d4b180ca8882626bd6adfc7bb98eb97550 Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> http://bugs.koha-community.org/show_bug.cgi?id=6473 Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 18959 [details] [review] Bug 9755 QA follow-up: move MARC-specific functionality to utility class This follow-up moves all the MARC-specific functionality of Koha::Record (now renamed to Koha::MetadataRecord) to a Koha::Util::MARC utility class. To test, run relevant unit tests: > prove t/Koha_MetadataRecord.t t/Koha_Util_MARC.t t/db_dependent/Koha_Authority.t and optionally try to merge a record. Filtered Filtered f6b051d4b180ca8882626bd6adfc7bb98eb97550 Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> http://bugs.koha-community.org/show_bug.cgi?id=6473 Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 18960 [details] [review] Bug 9755 QA follow-up: move MARC-specific functionality to utility class This follow-up moves all the MARC-specific functionality of Koha::Record (now renamed to Koha::MetadataRecord) to a Koha::Util::MARC utility class. To test, run relevant unit tests: > prove t/Koha_MetadataRecord.t t/Koha_Util_MARC.t t/db_dependent/Koha_Authority.t and optionally try to merge a record. Filtered Filtered f6b051d4b180ca8882626bd6adfc7bb98eb97550 Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> http://bugs.koha-community.org/show_bug.cgi?id=6473 Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 18961 [details] [review] Bug 9755 QA follow-up: move MARC-specific functionality to utility class This follow-up moves all the MARC-specific functionality of Koha::Record (now renamed to Koha::MetadataRecord) to a Koha::Util::MARC utility class. To test, run relevant unit tests: > prove t/Koha_MetadataRecord.t t/Koha_Util_MARC.t t/db_dependent/Koha_Authority.t and optionally try to merge a record. Filtered Filtered f6b051d4b180ca8882626bd6adfc7bb98eb97550 Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> http://bugs.koha-community.org/show_bug.cgi?id=6473 Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Patch tested and signoff automatically uploaded by Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 18962 [details] [review] Bug 9755: Refactor record merge functionality This patch refactors the merge record interface and code a little bit in preparation for making it possible to merge authority records. To test: 1) Apply patch. 2) Try merging two records: a) Create a list. b) Add two records you would like to (or be willing to) merge to said list. c) View said list. d) Check the checkboxes next to the two records you added. e) Click "Merge selected records." f) Choose a merge reference. g) Choose fields from each record that you want to keep. h) Click "Merge." 3) Confirm that your merged record has the fields and subfields you wanted. 4) Run the unit tests for the two files that were changed: prove t/Koha_Record.t t/db_dependent/Koha_Authority.t 5) Sign off. Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Filtered Filtered 04156f6cee8db3b11f71fb84eb0d6868956050db Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> http://bugs.koha-community.org/show_bug.cgi?id=6473 Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 18963 [details] [review] Bug 9755 QA follow-up: move MARC-specific functionality to utility class This follow-up moves all the MARC-specific functionality of Koha::Record (now renamed to Koha::MetadataRecord) to a Koha::Util::MARC utility class. To test, run relevant unit tests: > prove t/Koha_MetadataRecord.t t/Koha_Util_MARC.t t/db_dependent/Koha_Authority.t and optionally try to merge a record. Filtered Filtered f6b051d4b180ca8882626bd6adfc7bb98eb97550 Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> http://bugs.koha-community.org/show_bug.cgi?id=6473 Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 18971 [details] [review] Bug 9755: Refactor record merge functionality This patch refactors the merge record interface and code a little bit in preparation for making it possible to merge authority records. To test: 1) Apply patch. 2) Try merging two records: a) Create a list. b) Add two records you would like to (or be willing to) merge to said list. c) View said list. d) Check the checkboxes next to the two records you added. e) Click "Merge selected records." f) Choose a merge reference. g) Choose fields from each record that you want to keep. h) Click "Merge." 3) Confirm that your merged record has the fields and subfields you wanted. 4) Run the unit tests for the two files that were changed: prove t/Koha_Record.t t/db_dependent/Koha_Authority.t 5) Sign off. Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Filtered Filtered 04156f6cee8db3b11f71fb84eb0d6868956050db Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> http://bugs.koha-community.org/show_bug.cgi?id=6473 Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 18972 [details] [review] Bug 9755 QA follow-up: move MARC-specific functionality to utility class This follow-up moves all the MARC-specific functionality of Koha::Record (now renamed to Koha::MetadataRecord) to a Koha::Util::MARC utility class. To test, run relevant unit tests: > prove t/Koha_MetadataRecord.t t/Koha_Util_MARC.t t/db_dependent/Koha_Authority.t and optionally try to merge a record. Filtered Filtered f6b051d4b180ca8882626bd6adfc7bb98eb97550 Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> http://bugs.koha-community.org/show_bug.cgi?id=6473 Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Just getting this out of the signed off list.
Don't close this bug, it's very useful for testing git BZ please and thank you
Patch tested with a sandbox, by sandbox8 <sandboxes@biblibre.com>
Created attachment 19518 [details] [review] Bug 7143: Updating history and about page Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: <> Signed-off-by: name <emailaddress> Signed-off-by: sandbox8 <sandboxes@biblibre.com> Signed-off-by: sandbox8 <sandboxes@biblibre.com> Signed-off-by: sandbox8 <sandboxes@biblibre.com> http://bugs.koha-community.org/show_bug.cgi?id=6473 Signed-off-by: sandbox8 <sandboxes@biblibre.com>
Created attachment 19519 [details] [review] Bug 10496 - CCSR theme OPAC tabs to not show correct active state When jQueryUI was updated in the CCSR theme the corresponding CSS changes were not copied over at the same time, causing style problems with jQueryUI widgets. This patch makes the necessary changes. To test, apply the patch, clear your browser cache, and view any page which uses jQueryUI tabs (advanced search, bibliographic detail page). Tabs should look correct and correctly show which tab is active. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> CSS changes only. Confirmed problem in CCSR OPAC templates. Tested advanced search and detail pages in CCSR and prog. In order to fully test advanced search I added location and collection to AdvancedSearchTypes. Also tested the branch tooltip as I spotted some CSS added for that. Works beautifully, no problems found. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: <> Signed-off-by: name <emailaddress> Signed-off-by: sandbox8 <sandboxes@biblibre.com> Signed-off-by: sandbox8 <sandboxes@biblibre.com> Signed-off-by: sandbox8 <sandboxes@biblibre.com> Signed-off-by: sandbox8 <sandboxes@biblibre.com> http://bugs.koha-community.org/show_bug.cgi?id=6473 Signed-off-by: sandbox8 <sandboxes@biblibre.com> Signed-off-by: sandbox8 <sandboxes@biblibre.com>
Patch tested with a sandbox, by sandboxes <sandboxes@biblibre.com>
Created attachment 19591 [details] [review] Bug xxxxx: Modern::Perl should be used Signed-off-by: sandboxes <sandboxes@biblibre.com>
Created attachment 19592 [details] [review] Bug xxxxx: replace tmpl with tt Signed-off-by: sandboxes <sandboxes@biblibre.com>
Patch tested and signoff automatically uploaded by Jared Camins-Esakov <jcamins@cpbibliography.com> Testing upload again.
Patch tested and signoff automatically uploaded by Jared Camins-Esakov <jcamins@cpbibliography.com> Testing uploading again, this time with git-bz actually installed.
Patch tested and signoff automatically uploaded by Jared Camins-Esakov <jcamins@cpbibliography.com> Let's try this once more.
Patch tested and signoff automatically uploaded by Jared Camins-Esakov <jcamins@cpbibliography.com> Argh! Why does it hate me?!?
Patch tested and signoff automatically uploaded by Jared Camins-Esakov <jcamins@cpbibliography.com> The problem was git-bz wasn't fully configured, I think.
Patch tested and signoff automatically uploaded by Jared Camins-Esakov <jcamins@cpbibliography.com> Unfortunately, configuring git-bz is harder than it looks. Maybe.
Created attachment 19871 [details] [review] Bug 10403: add ability to change fund on receipt Right now there is no way to change the budget or fund when receiving an item, which is annoying, particularly at the end of the fiscal year when every item not already received has to be switched to the following year's budget. This patch adds the ability to change the budget and fund when receiving. To test: 1) Apply patch. 2) Create an order for a vendor, choosing a fund to use for that order. 3) Receive the order, leaving the fund unchanged. Make sure the fund did not change. 4) Create another order for a vendor, choosing a fund to use for that order. 5) Receive the order, this time changing the fund. Make sure the fund is changed. 6) Run the unit test: > prove t/db_dependent/Acquisition.t 7) Sign off. (Notes: this patch depends on the Acquisitions.t unit test improvements in bug 10274; the seemingly-unrelated change in SQLHelper quiets an irritating warning caused by the NewOrder call in ModReceiveOrder) Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Patch tested and signoff automatically uploaded by Jared Camins-Esakov <jcamins@cpbibliography.com> Ah-ha! When using koha-gitify, git-bz has to work for *TWO* users.
Patch tested and signoff automatically uploaded by Jared Camins-Esakov <jcamins@cpbibliography.com> Actually, it looks like Apache just massacres the environment.
Created attachment 19879 [details] [review] Signed off 0001-Bug-10402-Add-ability-to-enter-multiple-contacts.patch
Created attachment 19880 [details] [review] Signed off 0001-Bug-10402-Add-ability-to-enter-multiple-contacts.patch
Created attachment 19881 [details] [review] Signed off 0001-Bug-10402-Use-an-object-for-contacts.patch
Created attachment 19882 [details] [review] Signed off 0001-Bug-10402-Move-contacts-to-separate-table.patch
Patch tested and signoff automatically uploaded by Jared Camins-Esakov <jcamins@cpbibliography.com> And now we've lost my snarky comments? Oh no!
Created attachment 20011 [details] [review] Signed off 0001-Bug-10402-Move-contacts-to-separate-table.patch
Patch tested and signoff automatically uploaded by Jared Camins-Esakov <jcamins@cpbibliography.com> Clever commentary on the patch!
Created attachment 20012 [details] [review] Bug 9223: Multiple values of AdvancedSearchTypes in suggestions Suggestion form uses C4::Koha::GetSupportList to get a list of supports that can come from itemtypes or authoritized values LOC or CCODE. C4::Koha::GetSupportList uses AdvancedSearchTypes syspref like it has only one value. But this syspref can contain several values separated by a pipe. This patch introduces a new syspref SupportsAuthorizedValues to select wich authorized values category that represents the physical support (itemtypes by default, loc or ccode). These authorized values will be used in suggestion management, known as 'document type'. (Note that database field is still 'itemtype'). Test plan : ----------- - Set SupportsAuthorizedValues with itemtypes or loc or ccode - Get to suggestion form (OPAC or intranet) - Look at "Document type" combobox, it must contains descriptions of selected authorized values - Save the suggestion - Get to intranet suggestions management - Organize suggestions by document type => your suggestion must appear in a tab with its document type description
Created attachment 20013 [details] [review] Bug 9223: Add SupportsAuthorizedValues syspref (followup 1)
Created attachment 20014 [details] [review] Bug 9223 [Follow-up] Multiple values of AdvancedSearchTypes in suggestions This follow-up implements some things I think will improve on the previous patches: - Change the system preference name to "SuggestionsUseValues" - Change the description of the preference to "Suggestions can be submitted using the following authorized values:" - Move the new preference to the OPAC tab so that it is grouped with other suggestions-related preferences. - Add the option offer no itemtype/collection code chooser on the submission form. - Display the correct label on the submission form depending on the value of the SuggestionsUseValues preference. To test, apply this patch on top of the previous ones. Test submission of purchase suggestions through the OPAC and staff client with the SuggestionsUseValues preference set to all the various choices: item type, collection code, shelving location, and 'none.' The suggestion forms should look correct and work correctly. HOwEVER, neither the previous patches nor mine address the problem of the suggestions management page's "organize by" option, which is hard-coded to work with item types. Whether or not my patch is acceptable this issue will need to be addressed.
Created attachment 22477 [details] [review] git-bz testing patch Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Created attachment 22481 [details] [review] git-bz testing patch Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Created attachment 22482 [details] [review] git-bz testing patch Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Created attachment 22496 [details] [review] git-bz testing patch Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Created attachment 22502 [details] [review] git-bz testing patch Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Created attachment 22503 [details] [review] git-bz testing patch Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Created attachment 31958 [details] [review] Bug 12920 - Remove AllowRenewalLimitOverride from pl scripts, use Koha.Preference instead Per the new guidelines, AllowRenewalLimitOverride should not be referenced in circulation.pl or moremember.pl Test Plan: 1) Apply this patch 2) Go to circulation.pl 3) Ensure you can still override renewal limits with pref enabled 4) Ensure you can not override renewal limits with pref disabled 5) Go to moremember.pl 6) Repeat steps 3-4
Comment on attachment 31958 [details] [review] Bug 12920 - Remove AllowRenewalLimitOverride from pl scripts, use Koha.Preference instead just testing...
Created attachment 32444 [details] [review] Bug 9011 - Re-engineer circ anonymization, move to subroutine in C4::Circulation Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Created attachment 32445 [details] [review] Bug 9011 - Re-engineer circ anonymization, move to subroutine in C4::Circulation Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Created attachment 32446 [details] [review] Bug 9011 - Re-engineer circ anonymization, move to subroutine in C4::Circulation Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Created attachment 32447 [details] [review] Bug 9011 - Add the ability to store the last patron to return an item Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Created attachment 32448 [details] [review] Bug 9011 - Add support for StoreLastBorrower to AnonymiseIssueHistory Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Created attachment 32449 [details] [review] Bug 9011 [QA Followup] Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Created attachment 32450 [details] [review] Bug 9011 [QA Followup 2] - Add message to OPAC * Adds warning to OPAC if StoreLastBorrower is enabled * Updates db revision * Fixes POD error Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Created attachment 32451 [details] [review] Bug 9011 [QA Followup 3] - Update database schema files Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Created attachment 32452 [details] [review] Bug 9011 [QA Followup 4] - Add issue_id to issues tables Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Created attachment 34200 [details] [review] Bug 6473: this is a test
Patch tested with a sandbox, by sonia <sonia.bouis@univ-lyon3.fr>
Created attachment 34201 [details] [review] Bug 6473: this is a test Signed-off-by: sonia <sonia.bouis@univ-lyon3.fr>
Changing status..
Created attachment 34625 [details] [review] 3.16.x test push
Created attachment 34999 [details] [review] Bug 8992: Add the greybox include file for the bootstrap theme testing utf-8 valérie signed off
Created attachment 35130 [details] [review] Updated pod for AddMember Signed-off-by: Morag <the.invinnysible.one@gmail.com> http://bugs.koha-community.org/show_bug.cgi?id=12889
Created attachment 35269 [details] [review] Bug 6473 - Test bug for Git-bz utf-8 Test message (\xef\xbd\xa1\xef\xbd\xa5\xcf\x89\xef\xbd\xa5\xef\xbd\xa1)\xef\xbe\x89
Created attachment 35273 [details] [review] Bug 6473 - Test bug for Git-bz utf-8 Test message (\xef\xbd\xa1\xef\xbd\xa5\xcf\x89\xef\xbd\xa5\xef\xbd\xa1)\xef\xbe\x89
Created attachment 35274 [details] [review] Bug 6473 - Test bug for Git-bz utf-8 Test message (\xef\xbd\xa1\xef\xbd\xa5\xcf\x89\xef\xbd\xa5\xef\xbd\xa1)\xef\xbe\x89
Created attachment 35275 [details] [review] Bug 6473 - Test bug for Git-bz utf-8 Test message (。・ω・。)ノ
Created attachment 35276 [details] [review] Bug 6473 - Test bug for Git-bz utf-8 Test message (\xef\xbd\xa1\xef\xbd\xa5\xcf\x89\xef\xbd\xa5\xef\xbd\xa1)\xef\xbe\x89
Created attachment 35277 [details] [review] Bug 6473 - Test bug for Git-bz utf-8 Test message (。・ω・。)ノ
Created attachment 35279 [details] [review] Bug 6473 - Test bug for Git-bz utf-8 Test message (。・ω・。)ノ
Created attachment 35280 [details] [review] Bug 6473 - Test bug for Git-bz utf-8 Test message (。・ω・。)ノ
Created attachment 35303 [details] [review] Bug 6473: Test UTF8 in commit message 遺跡発見 áéíóú
Test UTF8 in commit message Seems still not to work: fatal: cannot convert from utf-8utf-8 to utf-8 Patch file contains: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=utf-8
Justin: What do you have in the i18n section of your .gitconfig ?
testing upgraded bugzilla
test 2
Created attachment 40954 [details] [review] Bug 6473 - Test bug for Git-bz utf-8 Test message (\xef\xbd\xa1\xef\xbd\xa5\xcf\x89\xef\xbd\xa5\xef\xbd\xa1)\xef\xbe\x89
Created attachment 40957 [details] [review] Bug 6473 - Test bug for Git-bz utf-8 Test message (\xef\xbd\xa1\xef\xbd\xa5\xcf\x89\xef\xbd\xa5\xef\xbd\xa1)\xef\xbe\x89
Created attachment 45345 [details] [review] Bug 12929: (followup) fix license I fix it myself. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> http://bugs.koha-community.org/show_bug.cgi?id=12919
Created attachment 45349 [details] [review] DBRev 3.23.00.000: 2016 Year of the Monkey
Created attachment 45731 [details] [review] Testing unicode stuff
Created attachment 45732 [details] [review] Bug 7143: Add link to www.openhub.net profile for Marc Véron This patch adds a link to www.openhub.net/p/koha/contributors/6618545408147 for Marc Véron.
Created attachment 45733 [details] [review] Bug 6473: Add link to www.openhub.net profile for Marc Véron This patch adds a link to www.openhub.net/p/koha/contributors/6618545408147 for Marc Véron.
Created attachment 45734 [details] [review] Bug 6473: Add link to www.openhub.net profile for Marc Véron This patch adds a link to www.openhub.net/p/koha/contributors/6618545408147 for Marc Véron.
*** Bug 15390 has been marked as a duplicate of this bug. ***
This is the most important comment ever.
Created attachment 47283 [details] [review] BUG 6473 test hmpf
Created attachment 47284 [details] [review] HAHAHA
Created attachment 47298 [details] [review] Bug 6473 Testing https
Created attachment 47299 [details] [review] Bug 6473 Testing https
Created attachment 47300 [details] [review] HAHAHA http://bugs.koha-community.org/show_bug.cgi?id=6473
Created attachment 47334 [details] [review] just a test
Created attachment 47336 [details] [review] Bug 15240: Do not process issues with a date due later than today There is no need to do this job in Perl, MySQL could do it instead. The idea is to only retrieve the issues info which could be overdued. To test: 1/ Run the script 2/ Apply the patch 3/ Run the script again, notice the exact same results but execution time is faster Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Patch tested with a sandbox, by Julian Maurice <julian.maurice@biblibre.com>
Created attachment 49083 [details] [review] Bug 6473: just a test https://bugs.koha-community.org/show_bug.cgi?id=6473 Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Created attachment 56974 [details] [review] [SIGNED-OFF] Bug 6473: just a test https://bugs.koha-community.org/show_bug.cgi?id=6473 Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> NOTE: Using KohaDevBox for the first time. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 61059 [details] [review] Bug 6473: just a test https://bugs.koha-community.org/show_bug.cgi?id=6473 Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Created attachment 61069 [details] [review] Bug 6473: just a test https://bugs.koha-community.org/show_bug.cgi?id=6473 Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Created attachment 62038 [details] [review] Bug 6473: just a test https://bugs.koha-community.org/show_bug.cgi?id=6473 Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Paul POULAIN <paul.poulain@biblibre.com>
test email
Patch tested with a sandbox, by Kyle M Hall <kyle@gmail.com>
Created attachment 65313 [details] [review] Bug 6473: just a test https://bugs.koha-community.org/show_bug.cgi?id=6473 Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Paul POULAIN <paul.poulain@biblibre.com> Signed-off-by: Kyle M Hall <kyle@gmail.com> Signed-off-by: BWS Sandboxes <ByWaterSandboxes@gmail.com>
test git bz edit
Created attachment 77301 [details] [review] Bug 12310: (QA follow-up) Add prefs to test too Test plan: Run t/db_dependent/UsageStats.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 78016 [details] [review] Bug 6473: test strange char in summary → + emoji in file name
(In reply to Liz Rea from comment #0) > Use this bug when testing your git-bz. :) > > DO YOUR WORST!! > > (yes, that's a challenge) ^_^ With an old git-bz version (or wrong branch), the above should cause an issue when attaching to this bug: Traceback (most recent call last): File "/usr/local/bin/git-bz", line 2632, in <module> do_attach(*args) File "/usr/local/bin/git-bz", line 1998, in do_attach attach_commits(bug, commits, edit_comments=global_options.edit) File "/usr/local/bin/git-bz", line 1913, in attach_commits description, body, obsoletes, statuses, patch_complexities, depends = edit_attachment_comment(bug, commit.subject, body) File "/usr/local/bin/git-bz", line 1866, in edit_attachment_comment lines = edit_template(template.getvalue()) File "/usr/local/bin/git-bz", line 811, in edit_template f.write(template) UnicodeEncodeError: 'ascii' codec can't encode character u'\u2192' in position 600: ordinal not in range(128)
(could be an issue even when attaching *another* patch in this bug, quite tricky then ^_^ )
qa comment test
Created attachment 79959 [details] [review] Bug 6473: just a test https://bugs.koha-community.org/show_bug.cgi?id=6473 Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Paul POULAIN <paul.poulain@biblibre.com> Signed-off-by: Kyle M Hall <kyle@gmail.com> Signed-off-by: BWS Sandboxes <ByWaterSandboxes@gmail.com>
Created attachment 80178 [details] [review] Updated LICENSE file to the latest version. Evil lines follow: --- a/README +++ b/README @@ -1,4 +1,4 @@ -Koha is a free software integrated library system. +Koha is a paid-for software integrated library system. Koha is distributed under the GNU GPL version 3 or later. Please read the file LICENSE for more details.
Created attachment 80179 [details] [review] Bug 6473: Test bug for Git-bz LICENSE file updated to reflect recent changes. And now for some more evil lines: --- a/README +++ b/README @@ -1,3 +1,3 @@ -Koha is a free software integrated library system. - +Koha is a paid-for software integrated library system. + Koha is distributed under the GNU GPL version 3 or later.
Created attachment 80180 [details] [review] Bug 6473: Test bug for Git-bz LICENSE file updated to reflect recent changes. --- a/README +++ a/README @@ -1,3 +1,3 @@ -Koha is a free software integrated library system. - +Koha is a paid-for software integrated library system. + Koha is distributed under the GNU GPL version 3 or later.
Created attachment 80181 [details] [review] Bug 6473: Test bug for Git-bz LICENSE file updated to reflect recent changes. README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/README +++ a/README @@ -1,3 +1,3 @@ -Koha is a free software integrated library system. - +Koha is a paid-for software integrated library system. + Koha is distributed under the GNU GPL version 3 or later.
Created attachment 80182 [details] [review] Bug 6473: Update LICENSE version and date This commit updates the version and date of the LICENSE. --- a/LICENSE +++ a/LICENSE @@ -51,3 +51,3 @@ modified versions of the software inside them, although the manufacturer -can do so. This is fundamentally incompatible with the aim of +can do so. This is fundamentally compatible with the aim of protecting users' freedom to change the software. The systematic
Testing kanban
moving back
Created attachment 84400 [details] [review] Test
Created attachment 86644 [details] [review] Bug 18736: Calculate tax depending on rounding Marcel's comments pointed out that while I tried to avoid storing rounded values it is required for tax generation. This patch makes that change and adds test coverage and POD for populate_order_with_prices To test: Follow plan on other patches, ensure that orders and totals match on the basket, invoice, and budget pages prove -v t/db_dependent/Acquisition/populate_order_with_prices.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 86645 [details] [review] Bug 18736: Calculate tax depending on rounding Marcel's comments pointed out that while I tried to avoid storing rounded values it is required for tax generation. This patch makes that change and adds test coverage and POD for populate_order_with_prices To test: Follow plan on other patches, ensure that orders and totals match on the basket, invoice, and budget pages prove -v t/db_dependent/Acquisition/populate_order_with_prices.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
*** Bug 22587 has been marked as a duplicate of this bug. ***
Created attachment 87152 [details] [review] Bug 18308 - Added step to onboarding tool to set minPasswordLength This patch increases the default minPasswordLength syspref value to 8 characters, for new installations. The final (6th step) of the onboarding tool is now a password length page where the default value of 8 can be altered. There is a security warning in red recommending to the user they keep the minimum length of the password at 8 characters or more. This patch also removes the atomicupdate .sql file to be run in an update to alter the default minPasswordLength value for existing Koha installations, based on tester feedback. Test plan: 1. Create a patron with a password less than 3 characters in length and notice that a red message is displayed by the input telling you that the password must be 3 characters minimum length 2. Query the database "select value from systempreferences where variable="minPasswordLength"; and notice the value is 3 3. Drop and recreate your database and restart memcached 4. Go through the web installer and onboarding tool. Noticing the last step of the onboarding tool is to create a circulation rule 5. Apply patch 6. Repeat step 3 7. Go through the web installer and onboarding tool. Noticing the last step of the onboarding tool is to set the minimum password length, the numerical input element has a default value of 8 and notice that it will go below 3 8. Repeat step 2 and notice the value is 8 9. In the onboarding tool change the minimum password length value to 7 and submit the form 10. Notice the completed page of the onboarding tool is displayed with the message that the minimum password length has been set. 11. Repeat step 2 and notice the value is now 7. 12. Try to create a patron in Intranet and OPAC with a password less than 7 characters and notice that a red message is displayed by the input telling you that the password must be 7 characters minimum length Sponsored-By: Catalyst IT Signed-off-by: David Bourgault <david.bourgault@inlibro.com>
Created attachment 88128 [details] [review] Bug 18308 - Added step to onboarding tool to set minPasswordLength This patch increases the default minPasswordLength syspref value to 8 characters, for new installations. The final (6th step) of the onboarding tool is now a password length page where the default value of 8 can be altered. There is a security warning in red recommending to the user they keep the minimum length of the password at 8 characters or more. This patch also removes the atomicupdate .sql file to be run in an update to alter the default minPasswordLength value for existing Koha installations, based on tester feedback. Test plan: 1. Create a patron with a password less than 3 characters in length and notice that a red message is displayed by the input telling you that the password must be 3 characters minimum length 2. Query the database "select value from systempreferences where variable="minPasswordLength"; and notice the value is 3 3. Drop and recreate your database and restart memcached 4. Go through the web installer and onboarding tool. Noticing the last step of the onboarding tool is to create a circulation rule 5. Apply patch 6. Repeat step 3 7. Go through the web installer and onboarding tool. Noticing the last step of the onboarding tool is to set the minimum password length, the numerical input element has a default value of 8 and notice that it will go below 3 8. Repeat step 2 and notice the value is 8 9. In the onboarding tool change the minimum password length value to 7 and submit the form 10. Notice the completed page of the onboarding tool is displayed with the message that the minimum password length has been set. 11. Repeat step 2 and notice the value is now 7. 12. Try to create a patron in Intranet and OPAC with a password less than 7 characters and notice that a red message is displayed by the input telling you that the password must be 7 characters minimum length Sponsored-By: Catalyst IT Signed-off-by: David Bourgault <david.bourgault@inlibro.com>
Created attachment 95586 [details] [review] Bug 24056 : Capitalization: Cash Register ID on cash register management page When editing a cash register, Cash register ID doesn't follow our capitalization guidelines. This patch fixes that. To Test: 1) Turn on cash register usage in the system prefere
Created attachment 95716 [details] [review] Add 'Test' to README.md
Created attachment 97394 [details] [review] Bug 15686 - Rename "item level holds" circ rule column to "OPAC item level holds" This patch changes the column heading on smart-rules.pl to indicate that it only effects item level holds on the OPAC side, rather than the intranet. To test: 1. Go to Administration, circulation and fine rules. 2. Observe incorrect heading on both the top and bottom of the table. 3. Apply the patch. 4. Repeat step 1. 5. Observe new headings. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 99026 [details] [review] Bug 17510: enable use of subfield 0 in MMT actions When adding MARC modification template (MMT) actions, if a subfield value of 0 (zero) is entered it will not show up in the action's description upon saving. Also, if you try to modify an authority or biblio record using actions that refer to subfield 0 the procedure will fail. This patch fixes that. Test plan: 0) Create a MARC modification template and add some actions to it, ideally testing all action types (Delete/Add new/Update existing or add new/Move/Copy/Copy and replace); make sure you input a 0 (integer zero) in the text box for the subfield value(s). 1) As you save each action, observe that subfield 0 ($0) is missing from the action description. 2) Home > Tools > Batch record modification: try to modify a biblio- graphic record using the modification template you just created. Observe that you get an error in the system logs if you click on 'Show MARC' or 'Modify selected records'. 3) Apply the patch. 4) Repeat steps 0-2. The subfield value ($0) should be displayed in the action description and the Batch record modification should work without problems.
Created attachment 99027 [details] [review] Bug 17510: update MMT-related unit tests The unit tests related to MARC modification templates need to be updated with extra tests specific to actions involving subfield 0. Test plan: 0) Apply the patch. 1) Run the updated unit tests, they should pass without any errors: $ prove t/SimpleMARC.t $ prove t/db_dependent/MarcModificationTemplates.t
There to link to a comment: just write: "bug 6473 comment 227" or: "comment 227"
*there => test
Formatting test > Amet voluptatibus hic facere quia enim alias. Exercitationem deserunt iusto totam. Eum quos ducimus magnam aut. Assumenda impedit recusandae commodi eos placeat consectetur ut. Impedit id id quam eveniet rerum. Sed ab officia provident non cupiditate.
Created attachment 114217 [details] [review] Bug 6473: Test bug for Git-bz add test for debian/control
Created attachment 114218 [details] [review] Bug 6473: Test bug for Git-bz add test for debian/control
Created attachment 114219 [details] [review] Bug 6473: Test bug for Git-bz add test for debian/control
Created attachment 114220 [details] [review] Bug 6473: Test bug for Git-bz add test for debian/control
Created attachment 114221 [details] [review] Bug 6473: Test bug for Git-bz add test for debian/control
Created attachment 114222 [details] [review] buildbot 20.12.00-0 for stretch: update debian/control modified: debian/control
Created attachment 114223 [details] [review] Bug 27030: Add missing perldoc for Processing hold status to C4::Reserves Test plan: Look into diff and confirm the comment does make sense Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 114224 [details] [review] buildbot 20.12.00-0 for stretch: update debian/control modified: debian/control
Created attachment 114225 [details] [review] Subject: [PATCH] buildbot 20.12.00-0 for stretch: update debian/control Content-Type: text/plain; charset="utf-8" modified: debian/control xxx
Created attachment 114226 [details] [review] Subject: [PATCH] buildbot 20.12.00-0 for stretch: update debian/control Content-Type: text/plain; charset="utf-8" modified: debian/control xxx
Test
Test impersonating
(In reply to David Cook from comment #246) > Test impersonating I think this will lock me out...
Created attachment 119255 [details] testing
The content of attachment 119255 [details] has been deleted
tested dependency following
test formatting |8 |657 |13:39:09|NULL | CPL| NULL|13:39:09 | CPL| NULL| TransferCancellation | Manual |9 |657 |13:39:09|13:39:09| CPL| NULL|NULL | FFL| NULL| Manual | NULL
|8|657|39:09|NULL |CPL|NUL|39:09|CPL|NUL|TransferCancellation|Manual |9|657|39:09|39:09|CPL|NUL|NUL |FFL|NUL|Manual |NULL
Created attachment 121181 [details] [review] Bug 6473: encoding test ✔❤★ aÄÄÄ Äãà éèà And in the body ✔❤★ aÄÄÄ Äãà éèà
Created attachment 131891 [details] [review] Bug 6473: encoding test ✔❤★ aÄÄÄ Äãà éèà And in the body ✔❤★ aÄÄÄ Äãà éèà
Created attachment 131893 [details] [review] Bug 6473: encoding test ✔❤★ aÄÄÄ Äãà éèà And in the body ✔❤★ aÄÄÄ Äãà éèà
Created attachment 131894 [details] [review] Bug 6473: encoding test ✔❤★ aÄÄÄ Äãà éèà And in the body ✔❤★ aÄÄÄ Äãà éèà
*** Bug 30558 has been marked as a duplicate of this bug. ***
Created attachment 134862 [details] [review] HOla Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 144109 [details] [review] Bug 6473 - Test bug for Git-bz ✔ ❤ ★ Bug 6473 - Test bug for Git-bz ✔ ❤ ★ Bug 6473 - Test bug for Git-bz ✔ ❤ ★
Created attachment 144144 [details] [review] Bug 6473 - 2th Test bug for Git-bz ✔ ❤ ★
Created attachment 144671 [details] [review] Bug 6473 - 2th Test bug for Git-bz ✔ ❤ ★ Signed-off-by: Bob Smith <bob.smith@test-email.com>
Created attachment 144672 [details] [review] Bug 6473 - 2th Test bug for Git-bz ✔ ❤ ★ Signed-off-by: Bob Smith <bob.smith@test-email.com> Signed-off-by: Bob Smith <bob.smith@test-email.com>
Created attachment 144673 [details] [review] Bug 6473 - 2th Test bug for Git-bz ✔ ❤ ★ Signed-off-by: Bob Smith <bob.smith@test-email.com> Signed-off-by: Bob Smith <bob.smith@test-email.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 147183 [details] [review] Bug 6473: Test patch This is a test patch
Created attachment 149030 [details] [review] Bug 20424: Add new zebra indexes for the last IFLA updates Signed-off-by: Sonia <sonia.bouis@univ-lyon3.fr> Signed-off-by: tkeromnes <thibault.keromnes@univ-paris8.fr>
Created attachment 149031 [details] [review] Bug 20424: (Followup) Add new zebra indexes for the last IFLA updates Signed-off-by: Sonia <sonia.bouis@univ-lyon3.fr> Signed-off-by: tkeromnes <thibault.keromnes@univ-paris8.fr>
Created attachment 149032 [details] [review] Bug 20424: remove zebra index for field 901 Signed-off-by: tkeromnes <thibault.keromnes@univ-paris8.fr>
Created attachment 149033 [details] [review] Bug 20424: provides biblio-zebra-indexdefs.xsl Signed-off-by: tkeromnes <thibault.keromnes@univ-paris8.fr>
Oh lol the above don't look like a test, I'm emailing them.
Created attachment 160566 [details] [review] Bug 6473 - 3th Test bug for Git-bz ✔ ❤ ★
Created attachment 160567 [details] [review] Bug 6473 - 3th Test bug for Git-bz ✔ ❤ ★
Created attachment 160568 [details] [review] Bug 6473 - 3th Test bug for Git-bz ✔ ❤ ★ - test line for the commit message - and one more test line for message
Testing of formatting of comments to see if it's the same between preview and a posted comment: - module: bookings code: BOOKING_CANCELLATION branchcode: "" name: "Booking cancellation notice" is_html: 1 title: "A library booking was cancelled" message_transport_type: email lang: default content: - "[%- PROCESS 'html_helpers.inc' -%]" - "[%- USE KohaDates -%]" - "Dear [%- INCLUDE 'patron-title.inc' patron => booking.patron -%],<br>" - "<br>" - "We regret to inform you, that the following booking has been cancelled.<br>" - "<br>" - "Title: [%- INCLUDE 'biblio-title.inc' biblio=booking.biblio link = 0 -%]<br>" - "<br>" - "Dates: [% booking.start_date | $KohaDates %] to [% booking.end_date | $KohaDates %]<br>" - "<br>" - "Reason: [% booking.cancellation_reason | html %]<br>" - "<br>" - "Kind regards<br>" - "<br>" - "[% booking.pickup_library.branchname %]"