Bug 40444

Summary: Add a test to ensure all Perl test files use Test::NoWarnings
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Test SuiteAssignee: Jonathan Druart <jonathan.druart>
Status: Needs Signoff --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low    
Version: unspecified   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 25515    
Bug Blocks: 40315, 40375, 40382, 40386, 40387, 40442, 40443, 40448, 40449    
Attachments: Bug 40444: Add a test to ensure all Perl test files use Test::NoWarnings
Bug 40444: Add a test to ensure all Perl test files use Test::NoWarnings
Bug 40444: Add Test::NoWarnings to xt tests

Description Jonathan Druart 2025-07-18 09:57:29 UTC
Once all children bug reports of bug 25515 will be pushed, only 7 (non-tribial) tests will be left.

We should add a test now to ensure no new occurrence will be added.
Comment 1 Jonathan Druart 2025-07-18 10:01:56 UTC
Created attachment 184319 [details] [review]
Bug 40444: Add a test to ensure all Perl test files use Test::NoWarnings

This patch adds a new xt test (xt/use-test-no-warnings.t) to make sure
all our Perl test files will use Test::NoWarnings.

It also adds Test::NoWarnings to some files that were missing it and
that didn't need any other changes.

However we still have 7 non-trivial tests that we will consider
exception for now, until they are fixed.

Test plan:
  prove xt/use-test-no-warnings.t
should return green.
And all other tests modified by this patch (the qa script will do that
for you)

You can also test the 2 selenium tests:
1. DROP and CREATE the DB
  DROP DATABASE koha_kohadev;
  CREATE DATABASE koha_kohadev;
  restart_all
2. KOHA_TESTING=1 prove t/db_dependent/selenium/00-onboarding.t
3. Repeat 1
2. KOHA_TESTING=1 prove t/db_dependent/selenium/01-installation.t
Comment 2 Jonathan Druart 2025-07-18 12:15:27 UTC
Created attachment 184364 [details] [review]
Bug 40444: Add a test to ensure all Perl test files use Test::NoWarnings

This patch adds a new xt test (xt/use-test-no-warnings.t) to make sure
all our Perl test files will use Test::NoWarnings.

It also adds Test::NoWarnings to some files that were missing it and
that didn't need any other changes.

However we still have 7 non-trivial tests that we will consider
exception for now, until they are fixed.

Test plan:
  prove xt/use-test-no-warnings.t
should return green.
And all other tests modified by this patch (the qa script will do that
for you)

You can also test the 2 selenium tests:
1. DROP and CREATE the DB
  DROP DATABASE koha_kohadev;
  CREATE DATABASE koha_kohadev;
  restart_all
2. KOHA_TESTING=1 prove t/db_dependent/selenium/00-onboarding.t
3. Repeat 1
2. KOHA_TESTING=1 prove t/db_dependent/selenium/01-installation.t
Comment 3 Jonathan Druart 2025-07-18 12:15:29 UTC
Created attachment 184365 [details] [review]
Bug 40444: Add Test::NoWarnings to xt tests