Description
Solene D
2022-06-13 12:36:07 UTC
Created attachment 136810 [details] [review] Bug 30952: added new icons and main scss files also touch includes files Created attachment 136812 [details] [review] Bug 30952: Catalogue module restyling Created attachment 136813 [details] [review] Bug 30952: Cataloguing Module Created attachment 136815 [details] [review] Bug 30952: Acquisition Module Created attachment 136816 [details] [review] Bug 30952: Admin Module Created attachment 136818 [details] [review] Bug 30952: Auth template Created attachment 136819 [details] [review] Bug 30952: Authority module Created attachment 136820 [details] [review] Bug 30952: Circulation Module Created attachment 136822 [details] [review] Bug 30952: Intranet main page Created attachment 136823 [details] [review] Bug 30952: Labels Module Created attachment 136825 [details] [review] Bug 30952: Patrons Module Created attachment 136827 [details] [review] Bug 30952: Plugins Module Created attachment 136828 [details] [review] Bug 30952: Suggestions Module Created attachment 136830 [details] [review] Bug 30952: Tools Module Created attachment 136831 [details] [review] Bug 30952: Virtualshelves Module Created attachment 136833 [details] [review] Bug 30952: Serials Module Created attachment 136834 [details] [review] Bug 30952: Reports Module Created attachment 136836 [details] [review] Bug 30952: Search bar Created attachment 136837 [details] [review] Bug 30952: add generated css files Created attachment 136839 [details] [review] Bug 30952: update css Created attachment 136840 [details] [review] Bug 30952: update include Created attachment 136842 [details] [review] Bug 30952: update patron and suggestion Created attachment 136844 [details] [review] Bug 30952: update search-engine Created attachment 136845 [details] [review] Bug 30952: correction includes Created attachment 136847 [details] [review] Bug 30952: update request Created attachment 136848 [details] [review] Bug 30952: update circulation (In reply to Solene D from comment #25) > Created attachment 136847 [details] [review] [review] > Bug 30952: update request There have been incorrect merge conflict fixed in this patch. At least: * badBibs has been removed by bug 30742 * Removal of "PROCESS patron_search_js" looks wrong. Created attachment 136878 [details] [review] Bug 30952: added new icons and main scss files also touch includes files Created attachment 136879 [details] [review] Bug 30952: Catalogue module restyling Created attachment 136880 [details] [review] Bug 30952: Cataloguing Module Created attachment 136881 [details] [review] Bug 30952: Acquisition Module Created attachment 136882 [details] [review] Bug 30952: Admin Module Created attachment 136883 [details] [review] Bug 30952: Auth template Created attachment 136884 [details] [review] Bug 30952: Authority module Created attachment 136885 [details] [review] Bug 30952: Circulation Module Created attachment 136886 [details] [review] Bug 30952: Intranet main page Created attachment 136887 [details] [review] Bug 30952: Labels Module Created attachment 136888 [details] [review] Bug 30952: Patrons Module Created attachment 136889 [details] [review] Bug 30952: Plugins Module Created attachment 136890 [details] [review] Bug 30952: Suggestions Module Created attachment 136891 [details] [review] Bug 30952: Tools Module Created attachment 136892 [details] [review] Bug 30952: Virtualshelves Module Created attachment 136893 [details] [review] Bug 30952: Serials Module Created attachment 136894 [details] [review] Bug 30952: Reports Module Created attachment 136895 [details] [review] Bug 30952: Search bar Created attachment 136896 [details] [review] Bug 30952: update include Created attachment 136897 [details] [review] Bug 30952: update patron and suggestion Created attachment 136898 [details] [review] Bug 30952: update search-engine Created attachment 136899 [details] [review] Bug 30952: correction includes Created attachment 136900 [details] [review] Bug 30952: update request Created attachment 136901 [details] [review] Bug 30952: update circulation Created attachment 136902 [details] [review] Bug 30952: css generation Please see comment 27. I think some merge conflicts haven't been resolved correctly. Created attachment 136950 [details] [review] Bug 30952: added new icons and main scss files also touch includes files Created attachment 136951 [details] [review] Bug 30952: Catalogue module restyling Created attachment 136952 [details] [review] Bug 30952: Cataloguing Module Created attachment 136953 [details] [review] Bug 30952: Acquisition Module Created attachment 136954 [details] [review] Bug 30952: Admin Module Created attachment 136955 [details] [review] Bug 30952: Auth template Created attachment 136956 [details] [review] Bug 30952: Authority module Created attachment 136957 [details] [review] Bug 30952: Circulation Module Created attachment 136958 [details] [review] Bug 30952: Intranet main page Created attachment 136959 [details] [review] Bug 30952: Labels Module Created attachment 136960 [details] [review] Bug 30952: Patrons Module Created attachment 136961 [details] [review] Bug 30952: Plugins Module Created attachment 136962 [details] [review] Bug 30952: Suggestions Module Created attachment 136963 [details] [review] Bug 30952: Tools Module Created attachment 136964 [details] [review] Bug 30952: Virtualshelves Module Created attachment 136965 [details] [review] Bug 30952: Serials Module Created attachment 136966 [details] [review] Bug 30952: Reports Module Created attachment 136967 [details] [review] Bug 30952: Search bar Created attachment 136968 [details] [review] Bug 30952: update include Created attachment 136969 [details] [review] Bug 30952: update patron and suggestion Created attachment 136970 [details] [review] Bug 30952: update search-engine Created attachment 136971 [details] [review] Bug 30952: correction includes Created attachment 136972 [details] [review] Bug 30952: update request Created attachment 136973 [details] [review] Bug 30952: update circulation Created attachment 136974 [details] [review] Bug 30952: css generation > Bug 30952: css generation This looks like the compiles CSS from SCSS, you should not attach a patch for that, it is compiled by testers : https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface Do we have a link to presentation ? Screen shots ? (In reply to Fridolin Somers from comment #79) > > Bug 30952: css generation > This looks like the compiles CSS from SCSS, you should not attach a patch > for that, it is compiled by testers : > https://wiki.koha-community.org/wiki/ > Working_with_SCSS_in_the_OPAC_and_staff_interface I used to attach the result of SCSS compilation as a separate patch, to ease testing (especially on sandboxes). It's not something we do anymore ? Anyway, we are still working on the patches (to fix bad conflict resolutions that happened during rebase). Fixed patches should be attached later this day, please be patient :) There is now a simple option to build the CSS from the sandbox manager so the compiled CSS patch isn't required. Personally, I was OK either way, so long as the compilation patch was distinct (as it's almost always a rebase issue, and is easier to just skip and rebuild when it's on it's own). Looking forward to playing with this.. I assume, given rebases are challenging, we're wanting to get testing done pretty quick... Adding myself to CC Can we also have a list of the changes we are expecting from these patches? Created attachment 137408 [details]
screenshot of the new interface : the main menu
Created attachment 137409 [details]
screenshot of the new interface : return page
Created attachment 137410 [details]
screenshot of the new interface : patron details
Created attachment 137411 [details]
screenshot of the new interface : patron details
This new interface includes modifications of the main colors, the buttons, the menus, the searchbar... (cf screenshots) Any feedback will be helpfull. :) We decided to remove the css from the patch, you'll have to generate it to test the interface. Created attachment 137414 [details] [review] Bug 30952: Staff interface redesign Created attachment 137415 [details] [review] Bug 30952: script searchbar Created attachment 137416 [details] [review] Bug 30952: update aside menu Created attachment 137417 [details] [review] Bug 30952: update buttons toolbar Created attachment 137418 [details] [review] Bug 30952: update filter search Created attachment 137419 [details] [review] Bug 30952: renaming classes Created attachment 137420 [details] [review] Bug 30952: update main menu 1. Lot of French in the patches: * "onclick="clique(this)"" * <p class="plusdessous" id="filters"> Plus dessous?! * <ul id="taille"> * id="lientype", french, "link type" 2. Not descriptive: * id="button_1", button_2, button_3, button_4 3. Lot of commented code. 4. This seems wrong: + function toggle(elem){style="width: calc(301px);" 5. identical JS code copy/pasted all around: functions focusInput, toggle, clique, fold, taille, etc. 6. There is a lot of unnecessary indentation changes, that will lead to unnecessary conflicts... On the home page, HTML from the IntranetmainUserblock system preference gets pushed under the news area (id="area-news") in the new interface. It should be under the menu items. "Patrons requesting updates" used to be in a div called id="area-pending" and it used to fall under the menu items. Now it's under the news area in an id="area-news" div. This same problem applies to Suggestions pending and Quote of the day. They should all be under the menu items. My library make extensive use of the news area to share links to outside resources and putting these things underneath the news area makes the alerts, quote of the day and IntranetmainUserblock means that users may have to scroll 40 feet down the page in order to access relevant information and alerts. Code mirror text in system preferences like IntranetUserJS is centered? That's just crazy. The "area-news" id is repeated several times on the home page for news, quote of the day, and alerts. (In reply to George Williams (NEKLS) from comment #98) > Code mirror text in system preferences like IntranetUserJS is centered? > > That's just crazy. Agreed. I feel the same way about centered text in the search results. It makes it harder to distinguish items and visually track certain characteristics that would always be in the same place in left justified text. Let's keep the comments constructive please. I'm sure there will be lots of follow-ups and fixes but let's remember lots of work has already happened and is good. Now it's time for us to all help polish and fix inevitable issues that may have crept in. [U+1F642] On that front, I wonder if it might be helpful to have a shared branch to work on together for the final submission? Perhaps a merge-request flow for fixes managed by Solene (with a little help from Julian or someone else) There are coders here happy to help guide this through. Thanks for the feedback! Obviously the centered text in system preferences is a mistake and will be fixed ;) Issues raised by comment 97 will be fixed too Jonathan, we are aware of the problems you mention. Solène is working on it (note that (5) is already fixed by attachment 137415 [details] [review]) Martin, I think a shared branch is an interesting idea, but maybe for later when things are more stable (lots of rewrites/indentation fixes/... at the moment) Also, we'll probably set up a public instance so that people can test it easily. Hi! Is https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137408 the latest update of the Main Menu? It seems odd that "Lists" is now on a line with "Advanced Search" and "Item Search," since Lists is very much tied to one's login--it takes one to one's own lists & the lists one has access to. I like Reports being moved to a column with Tools and Administration. But the "About Koha" logo seems out of place here--should it be next to the Koha logo at the center bottom of the screen? I know this is probably only a dream at this point, but it would be great for the user to be able to click/tap-and-drag these buttons to a custom layout based on their login, and to hide less often used ones. I'd have my top buttons be Cataloging, Authorities, Advanced Search, and Item Search, with my second row of buttons being Serials, Reports, Tools, Administration, and I'd hide the Acquisitions button (and access the module via the pull-down menus at the top). There's a lovely typo in the pull-down menus at the top, "Catalogage." Although I do adore the idea that this makes cataloging seem more en-gaging, it should probably match the button that says "Cataloging." And while I'm at it, can we please standardize Catalog vs. Catalogue, and Cataloging vs. Cataloguing? Can we just put the "u" in or leave it out everywhere? I'd say put it in, and drag we USians into the spelling of the international community! (Next let's work on making us metric.:) ) "Selections pending approval" at the bottom of the left column would be ignored at my library, and would get pushed down by staff client news. It's something that needs paying attention to--it's a, "Hey! You! You need to take care of this!" item, so although I like it over in the column, I'd put it at the top in an alert color, or prefaced with the login name to catch the eye of the user, e.g., for me, "Hello, Heather! Suggestions pending approval..." I don't have any comments yet on other areas--I don't really use the Basic Bib Editor, but am eager to see what the Advanced Editor and/or Authorities might look like. Lovely work!! So exciting! As far as accessibility goes, I don't like putting the search input (#header_search) in the header and I don't like removing the text labels for the different types searches and replacing them only with icons. I have staff that are older and their vision isn't great and relying solely on icons to select the function of the search input is going to be difficult for them. I'd either like to see a return to the text tabs underneath the search input or, at the very least, making the hint text that appears when you hover over the icons much, much larger. The bottom line is that I have staff with vision issues that are going to need a bigger search input. The one in the current iteration of this interface is too small and difficult to read. I agree with George in comment 94. I am a visually impaired person who finds this search input display very difficult to read. The input box is not big enough for me to comfortably use it and the icons are too small to distinguish from each other without zooming in. I prefer the text labels underneath the input (maybe because that is what I'm used to) If the icons could be made much larger and include plenty of space between them that would help a great deal. Including the input box in the #header_search makes it less prominent to me. I would prefer it to have its own dedicated area of the screen. Additionally, our library uses the extra white space in the #header_search to add additional links which have streamlined our operations. Placing the input box here would make us lose that ability. We have an extremely busy Information Desk at out library so staff being able to clearly see the screen and quickly navigate around while a lot of patrons are waiting for assistance is of prime importance to us. Think this needs another rebase.. I had a go but there are a lot of template changes going on here so it's non-trivial to get right. (In reply to Martin Renvoize from comment #106) > Think this needs another rebase.. I had a go but there are a lot of template > changes going on here so it's non-trivial to get right. It's coming soon. Solène has been working on fixes and also on reducing the number of template changes to ease rebase. We'll try to submit an up-to-date patch today. Created attachment 137744 [details] [review] Bug 30952: Staff interface redesign Created attachment 137767 [details] [review] Bug 30952: (follow-up) Fix linting errors in SCSS This patch makes some corrections to the style of modified SCSS: - Space before "{" - No leading zeroes in number values - Upper case hex codes - Multi-line comment style - Use "border: 0" instead of "border: none" - Remove vendor prefixes - Remove commented-out declarations - Put each selector on a separate line The patch should have no visible effects on the style of the interface. Created attachment 137768 [details] [review] Bug 30952: (follow-up) Correct whitespace errors Tab characters are forbidden, as is space at the end of lines. There are a few other errors highlighted by the QA tool, so please run that provide a follow-up. Created attachment 137775 [details] [review] Bug 30952: (follow-up) Fix linting errors in SCSS This patch makes some corrections to the style of modified SCSS: - Space before "{" - No leading zeroes in number values - Upper case hex codes - Multi-line comment style - Use "border: 0" instead of "border: none" - Remove vendor prefixes - Remove commented-out declarations - Put each selector on a separate line The patch should have no visible effects on the style of the interface. Created attachment 137776 [details] [review] Bug 30952: (follow-up) Correct whitespace errors Tab characters are forbidden, as is space at the end of lines. Agreeing with the comments of George & Barbara on accessibility & design of the header (comments 104, 105). Search bar, icon sizes, et al. as presently configured would present *many* issues to staff. A couple other notes on issues in the current sandbox that are no doubt being worked on: Patrons page (members-home.pl): layout issues Lists page (shelves.pl): Template process failed: file error - parse error Cab Vinton/ Plaistow PL How hard would it be to implement a expand/collapse feature to display a minimal/full header? I think it would fit everybody's needs. (In reply to Jonathan Druart from comment #115) > How hard would it be to implement a expand/collapse feature to display a > minimal/full header? I think it would fit everybody's needs. If the logic of not having text labels on the buttons is to make the interface responsive, perhaps the labels could appear on desktops but switch to icons only on smaller screen sizes? (In reply to Benjamin Daeuber from comment #116) > (In reply to Jonathan Druart from comment #115) > > How hard would it be to implement a expand/collapse feature to display a > > minimal/full header? I think it would fit everybody's needs. > > If the logic of not having text labels on the buttons is to make the > interface responsive, perhaps the labels could appear on desktops but switch > to icons only on smaller screen sizes? I like both ideas. Maybe it would work better if the select options would be below or above the search form again. Another thought here: there is not much room currently for additional links added by IntranetNav. A longer register name or library name would also take up more space - if we leave a bit more space, we could fit these better too. Addressing accessibility concerns presented by others, I have to second this. If categories on the home page are no longer neatly grouped, navigation and orientation will take longer and I anticipate my staff having difficulty with this. In present format, eyes do tend to drift across the page. Created attachment 137994 [details] [review] Bug 30952: (follow-up) Add Poppins font assets This patch adds web font versions of Poppins, a font licensed under the Open Font License. Providing a web version is necessary because not everyone will have Poppins locally installed. SCSS has been updated so that the staff interface uses this font by default. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Visit various pages in the staff interface to confirm that the correct font is being used. Created attachment 138091 [details] [review] Bug 30952: Staff interface redesign (header) What this patch does: - change the navigation bar style - change the breadcrumbs style - change the "last borrower" link style - move the search bar inside the navigation bar - move the help link to the same row as the breadcrumbs Created attachment 138092 [details] [review] Bug 30952: Add Poppins font assets Created attachment 138093 [details] [review] Bug 30952: Move "Go to advanced/item search" link to toolbar Created attachment 138094 [details] [review] Bug 30952: Staff interface redesign (toolbar) Created attachment 138095 [details] [review] Bug 30952: Change checkout, checkin and renew forms Created attachment 138096 [details] [review] Bug 30952: Staff interface redesign (main page) Created attachment 138097 [details] [review] Bug 30952: Small adjustments in search results page - Move Z39.50 search button to a toolbar - Use btn and btn-link classes for "Select all" and "Clear all" buttons Created attachment 138098 [details] [review] Bug 30952: Change MARC tags toolbar style Created attachment 138099 [details] [review] Bug 30952: Change login page style Created attachment 138100 [details] [review] Bug 30952: Change sysprefs nav menu style Created attachment 138101 [details] [review] Bug 30952: Change default button style Created attachment 138102 [details] [review] Bug 30952: Change tables style Created attachment 138103 [details] [review] Bug 30952: The rest of CSS changes There is still work to do to split this patch correctly into several more logical patches. Consider this patch a WIP. I have done a bit of cleanup in the patch and split it in more logical patches. I tried to remove all template changes that were not necessary. Hopefully it will be easier to review. There are some changes too (non-exhaustive list): - The search bar in the header has been "fixed". It's still the same with the same accessibility issues mentioned earlier, but at least it should be displayed correctly on all pages, even when the search form have more than one input. There was some JS code used to fix sizes and positioning, it's gone. All positioning is done in CSS only now - The main page regained its old appearance (only colors are different). - The circulation home page went back to old boring links (still WIP) - There was some "UIKit" icons added in the previous patch, but only two of those were used, and those two have an equivalent icon in FontAwesome (arrow-right and sliders). I decided to remove all UIKit icons from the patch and use FontAwesome instead. - QA tests are green :) There is still work to do, but you can already have a look at it on the sandbox: https://staff-bug30952.sandboxes.biblibre.eu (user/password as usual) I also set up a github repository here: https://github.com/jajm/koha-staff-interface-redesign I think it can be useful to organize feedbacks/decisions: - If you see something that need to be fixed you can open an issue https://github.com/jajm/koha-staff-interface-redesign/issues/new - If you want to discuss something, you can create a new discussion https://github.com/jajm/koha-staff-interface-redesign/discussions/new The search bar is always returning to "Check Out". If I do a catalog search, the bar will return to "Check out" and I need to manually return it to "Search Catalog" each time. Also, I think the entry in that bar should persist even as you switch contexts (so if I type something in and realize it's on Check out, I should be able to switch to Search and not retype). The floating search header bar has a transparent background, meaning that as items scroll underneath it, you can no longer read the bar properly. Moved my comments to the github issues board. I've taken a different approach regarding the next step with this work. I think we should be working with a set of templates with as few changes as possible as we adjust the CSS. I think reducing template changes is going to make testing easier. Some template change reversions can be replaced with CSS changes. Others can wait until we have more consensus about the design in general. https://gitlab.com/koha-dev/koha-dev/-/commits/wip-bug-30952-staff-redesign Created attachment 138245 [details] [review] Bug 30952: (follow-up) Undo change to Home breadcrumb Created attachment 138246 [details] [review] Bug 30952: Undo change to Home breadcrumb for remaining templates Created attachment 138247 [details] [review] Bug 30952: Replace "Home" by icon in breadcrumbs Owen, I took one of your patches for removing for undoing changes to the breadcrumb, but I didn't take the last patch like I said I would do. I believe it tries to fix things that are already fixed, and for the home icon I changed the CSS to use the FontAwesome icon instead (looks better than the inline SVG IMO) Created attachment 138293 [details] [review] Bug 30952: Fix "rows" forms Issue #7 Created attachment 138299 [details] [review] Bug 30952: Fix position shift when hovering .linktools links Issue #6 Created attachment 138300 [details] [review] Bug 30952: Fix the 'keep_text' feature of the search bar Text in one form should be copied in other forms when switching tab Issue #2 Created attachment 138302 [details] [review] Bug 30952: Show the search catalog form by default in cat-search.inc Issue #1 Sandbox recreated will all patches: https://staff-bug30952.sandboxes.biblibre.eu (In reply to Julian Maurice from comment #145) > Sandbox recreated will all patches: > https://staff-bug30952.sandboxes.biblibre.eu I've posted the link into the discussion on the mailing list - thanks a lot for setting this up! A couple of alternative ideas for the search header: https://imgur.com/a/HRwtZQH I like those alternatives much better, especially having the search input box separated from the header. Having text as opposed to icons is important to our busy information desk staff. This makes sense to me both stylistically and functionally. I like "Horizontal search header form with forms inline with each button" alternative. Good work. Thanks Michal. That's the one I prefer too. At first I was concerned about it being confusing for users accustomed to the static tabs (always in the same place no matter which form is selected) but now I think it might be useful to have the visual clue of the position of the form to help the user orient themselves. (In reply to Michal Denar from comment #149) > I like "Horizontal search header form with forms inline with each button" > alternative. Good work. Same for me. This change is quite complex, we may want to separate it on another bug report so that this one may go faster. (In reply to Fridolin Somers from comment #151) > (In reply to Michal Denar from comment #149) > > I like "Horizontal search header form with forms inline with each button" > > alternative. Good work. > > Same for me. > > This change is quite complex, we may want to separate it on another bug > report so that this one may go faster. Not sure if this is ready to be pushed with our without the changes to search bar, but not sure if we should rush things. The search bar is probably the most important bit to get right. I like the second option better too. Would love to see a mock-up that includes IntranetAddMastheadLibraryPulldown and IntranetCatalogSearchPulldown. Hello all, There are around 12 issues that have been risen on https://github.com/jajm/koha-staff-interface-redesign/issues Most are bugs, Julian will take care of them in the next 2 weeks. Regarding the search bar, I'm very reluctant to change things : - it has been discussed in web meetings before the development. Changing things now is a little bit unfair - maintaining the branch is a pain : every patch with something in a template requires a rebase. Thus, the earlier the whole thing is pushed, the better it is. It will also let us time to find any unseen bug. - we can always discuss & adjust the search bar after the main merge At the end, my proposal would be: - Julian Fixes bugs - we merge the patch as soon as possible, with the goal to have it for 22.11. - we open a separate bug for the search bar. Maybe comments from libraries using the proposed version will also help us find the best possible solution. I'm planning to continue BibLibre effort in order to modernize the staff interface. PS in case you missed the information: Solene is no more with us (back to school) (In reply to Paul Poulain from comment #154) > Hello all, > There are around 12 issues that have been risen on > https://github.com/jajm/koha-staff-interface-redesign/issues > Most are bugs, Julian will take care of them in the next 2 weeks. > > Regarding the search bar, I'm very reluctant to change things : > - it has been discussed in web meetings before the development. Changing > things now is a little bit unfair > - maintaining the branch is a pain : every patch with something in a > template requires a rebase. Thus, the earlier the whole thing is pushed, the > better it is. It will also let us time to find any unseen bug. > - we can always discuss & adjust the search bar after the main merge > > At the end, my proposal would be: > - Julian Fixes bugs > - we merge the patch as soon as possible, with the goal to have it for 22.11. > - we open a separate bug for the search bar. Maybe comments from libraries > using the proposed version will also help us find the best possible > solution. I'm planning to continue BibLibre effort in order to modernize the > staff interface. > > PS in case you missed the information: Solene is no more with us (back to > school) It feels to me that it is getting too late in the 22.11 cycle to push this and still have time to work out any unseen bugs. Would it not be more prudent to have this ready for a very early push to 23.05? That way we would have ample time to work out those bugs? (In reply to Lucas Gass from comment #155) > Would it not be more > prudent to have this ready for a very early push to 23.05? That way we would > have ample time to work out those bugs? Agreed. Also, the search bar is arguably the single most important interface piece in all of Koha. It's interacted with hundreds of times a day here so getting it right is an absolute must, in my opinion. It will be the decision of the Release Manager. Maybe I'm optimistic, but I prefer to keep in mind the 22.11 goal, knowing it's optimistic, and not say "well, we've 6 more months", and let the topic fall in a pit. Created attachment 140117 [details] [review] Bug 30952: Staff interface redesign (header) What this patch does: - change the navigation bar style - change the breadcrumbs style - change the "last borrower" link style - move the search bar inside the navigation bar - move the help link to the same row as the breadcrumbs Created attachment 140118 [details] [review] Bug 30952: Add Poppins font assets Created attachment 140119 [details] [review] Bug 30952: Move "Go to advanced/item search" link to toolbar Created attachment 140120 [details] [review] Bug 30952: Staff interface redesign (toolbar) Created attachment 140121 [details] [review] Bug 30952: Change checkout, checkin and renew forms Created attachment 140122 [details] [review] Bug 30952: Staff interface redesign (main page) Created attachment 140123 [details] [review] Bug 30952: Small adjustments in search results page - Move Z39.50 search button to a toolbar - Use btn and btn-link classes for "Select all" and "Clear all" buttons Created attachment 140124 [details] [review] Bug 30952: Change MARC tags toolbar style Created attachment 140125 [details] [review] Bug 30952: Change login page style Created attachment 140126 [details] [review] Bug 30952: Change sysprefs nav menu style Created attachment 140127 [details] [review] Bug 30952: Change default button style Created attachment 140128 [details] [review] Bug 30952: Change tables style Created attachment 140129 [details] [review] Bug 30952: The rest of CSS changes There is still work to do to split this patch correctly into several more logical patches. Consider this patch a WIP. Created attachment 140130 [details] [review] Bug 30952: (follow-up) Undo change to Home breadcrumb Created attachment 140131 [details] [review] Bug 30952: Undo change to Home breadcrumb for remaining templates Created attachment 140132 [details] [review] Bug 30952: Replace "Home" by icon in breadcrumbs Created attachment 140133 [details] [review] Bug 30952: Fix "rows" forms Issue #7 Created attachment 140134 [details] [review] Bug 30952: Fix position shift when hovering .linktools links Issue #6 Created attachment 140135 [details] [review] Bug 30952: Fix the 'keep_text' feature of the search bar Text in one form should be copied in other forms when switching tab Issue #2 Created attachment 140136 [details] [review] Bug 30952: Show the search catalog form by default in cat-search.inc Issue #1 Created attachment 140137 [details] [review] Bug 30952: Move the toolbar back to the left Issue #8 Created attachment 140138 [details] [review] Bug 30952: Fix alignment of search results Issue #11 Created attachment 140139 [details] [review] Bug 30952: Fix "browse patrons by last name" display Issue #13 Created attachment 140140 [details] [review] Bug 30952: Fix left padding of sidebar Issue #14 Created attachment 140141 [details] [review] Bug 30952: Fix lists display on patron detail page Issue #15 Created attachment 140142 [details] [review] Bug 30952: Fix background color of dialogs (message, alert, error) Issue #9 Created attachment 140143 [details] [review] Bug 30952: Increase contrast between green text and white/grey background Issue #10 All github issues were addressed in the last patches, at least partially * All patches are rebased on master and the sandbox was rebuilt: https://staff-bug30952.sandboxes.biblibre.eu/cgi-bin/koha/mainpage.pl Please test and give feedback. About the search bar, Owen, where is the code ? :) I'd like to test it. Personally I prefer the "static tabs" alternative. It's weird to see the text input move from left to right. Also some buttons are always on one side of the input, while other buttons can be on either side, depending on which form is selected. It's a little bit confusing. * there are still contrast issues - see https://github.com/jajm/koha-staff-interface-redesign/issues/10 - which requires more work (In reply to Julian Maurice from comment #185) > About the search bar, Owen, where is the code ? https://gitlab.com/koha-dev/koha-dev/-/tree/bug-30952-search-redesign I just rebased it on your latest patches. Was it agreed upon to not use the tab design from the original work? What we have now: https://snipboard.io/A9SOz7.jpg What it would look like with the original style: https://snipboard.io/2FJSnl.jpg (In reply to Owen Leonard from comment #187) > Was it agreed upon to not use the tab design from the original work? > > What we have now: https://snipboard.io/A9SOz7.jpg > > What it would look like with the original style: > https://snipboard.io/2FJSnl.jpg +1000 for the "now" version ! As a middle ground for the search bar changes stuff as it appears to be the most contentious part.. I re-read the comments on the Mock-ups and Myka's comments seems really relevant.
> Can having the persistent search at the top throughout the site continue to be an option (toggle on/off) in admin settings?
We could fairly easily get the best of both worlds as an interim option.. with a system preference that either embeds the search stuff in the top header OR uses Owens separate bar as the alternate option... Thoughts?
(In reply to Paul Poulain from comment #188) > (In reply to Owen Leonard from comment #187) > > Was it agreed upon to not use the tab design from the original work? > > > > What we have now: https://snipboard.io/A9SOz7.jpg > > > > What it would look like with the original style: > > https://snipboard.io/2FJSnl.jpg > > +1000 for the "now" version ! I raised a github issue for this.. I think there's more to it than just the tab based nav.. the card layout isn't as the mock-ups suggested either and I think that lack of cards causes some of the difficulties Jonathan D and I raised regarding the right aligned toolbar buttons and lack of toolbar background making the buttons lose natural focus. https://github.com/jajm/koha-staff-interface-redesign/issues/17 and https://github.com/jajm/koha-staff-interface-redesign/issues/8 PTFS-E have a group of us scheduled to go through the new UI this Friday (9th September).. hopefully, it'll yield lots of good feedback and help drive this through. (In reply to Benjamin Daeuber from comment #156) > (In reply to Lucas Gass from comment #155) > > Would it not be more > > prudent to have this ready for a very early push to 23.05? That way we would > > have ample time to work out those bugs? > > Agreed. > > Also, the search bar is arguably the single most important interface piece > in all of Koha. It's interacted with hundreds of times a day here so getting > it right is an absolute must, in my opinion. I think we can not release without this being fixed. There was a lot of feedback on exactly this piece from librarians on the mock-ups. We can not just ignore that. I'd also like some tests done with different languages including non-latin ones. Created attachment 140371 [details] [review] Bug 30952: Change color of btn-primary and use that for Check out button Created attachment 140372 [details] [review] Bug 30952: Add "card" layout to the checkout page Also fix the label positioning Created attachment 140373 [details] [review] Bug 30952: Move search bar below navbar and reduce navbar height Created attachment 140374 [details] [review] Bug 30952: Add card layout to patron messages in moremember.pl The last patches contain a few bugfixes related to https://github.com/jajm/koha-staff-interface-redesign/issues/17 and the move of the search bar. It looks like this now : https://snipboard.io/ioTBnV.jpg This is close to what Owen did, but with all the tabs on the left, and I kept the icons Which one do you prefer: - All tabs on the left ? - All tabs on the right ? - Form in between tabs ? With or without icons ? @julian : am I wrong or the sandbox has not been updated with the last patch ? https://staff-bug30952.sandboxes.biblibre.eu/ (however: I like the screenshot, more than the search inside the menu: more clear and less risk of overwriting something with too many information on the menu line) (In reply to Paul Poulain from comment #198) > @julian : am I wrong or the sandbox has not been updated with the last patch > ? > https://staff-bug30952.sandboxes.biblibre.eu/ I'm surprised it still exists because it is not listed on the sandboxes page... (so we cannot delete it :/) I'm not sure what's happening with the sandboxes but I decided to not use them anymore as they tend to break after some (short) time. So you're right, the sandbox is not up to date. If you want an up-to-date version you have to create a new sandbox. I summarized the search bar options in a poll on github: https://github.com/jajm/koha-staff-interface-redesign/discussions/34 Please vote :)
> If you want an up-to-date version you have to create a new sandbox.
Are we supposed to use the patches here or the git branch? If the git branch: how can I set this up on the sandbox? I failed spectacularly last time I tried the use the branch options in the sandbox form.
I update both at the same time, so you can use the method you prefer (or in that case, the one that works ;)) Created attachment 140433 [details] [review] Bug 30952: Fix background of search header Issue #3 Created attachment 140435 [details] [review] Bug 30952: Fix item edit form Issue #31 Created attachment 140459 [details] [review] Bug 30952: Move 'Clear filter' next to filter in table headers Issue #16 (In reply to Julian Maurice from comment #202) > I update both at the same time, so you can use the method you prefer (or in > that case, the one that works ;)) No luck with the sandbox, I "build CSS" after spinning it up: https://staff-gui.sandboxes.biblibre.eu/ (In reply to Katrin Fischer from comment #206) > (In reply to Julian Maurice from comment #202) > > I update both at the same time, so you can use the method you prefer (or in > > that case, the one that works ;)) > > No luck with the sandbox, I "build CSS" after spinning it up: > https://staff-gui.sandboxes.biblibre.eu/ Stubborn browser cache - all good now. Created attachment 140460 [details] [review] Bug 30952: Change circulation home page links to buttons Apply the same style to staff home page links Issue #18 Created attachment 140512 [details] [review] Bug 30952: Fix table headers Issue #16 Created attachment 140513 [details] [review] Bug 30952: Fix remaining header search bars Created attachment 140514 [details] [review] Bug 30952: Fix background of "Clear filter" button Issue #16 Created attachment 140515 [details] [review] Bug 30952: Fix contrast issue on patron brief view Issue #19 Created attachment 140516 [details] [review] Bug 30952: Remove white text shadow from buttons Issue #20 Created attachment 140517 [details] [review] Bug 30952: Fix pagination colors Issue #21 Hi Julian, a rebase might be required, I am getting an error on the sandbox trying to apply the patches. And the git log stays at current master: https://sandboxes.biblibre.eu/git_log/gui Created attachment 140519 [details] [review] Bug 30952: Staff interface redesign (header) What this patch does: - change the navigation bar style - change the breadcrumbs style - change the "last borrower" link style - move the search bar inside the navigation bar - move the help link to the same row as the breadcrumbs Created attachment 140520 [details] [review] Bug 30952: Add Poppins font assets Created attachment 140521 [details] [review] Bug 30952: Move "Go to advanced/item search" link to toolbar Created attachment 140522 [details] [review] Bug 30952: Staff interface redesign (toolbar) Created attachment 140523 [details] [review] Bug 30952: Change checkout, checkin and renew forms Created attachment 140524 [details] [review] Bug 30952: Staff interface redesign (main page) Created attachment 140525 [details] [review] Bug 30952: Small adjustments in search results page - Move Z39.50 search button to a toolbar - Use btn and btn-link classes for "Select all" and "Clear all" buttons Created attachment 140526 [details] [review] Bug 30952: Change MARC tags toolbar style Created attachment 140527 [details] [review] Bug 30952: Change login page style Created attachment 140528 [details] [review] Bug 30952: Change sysprefs nav menu style Created attachment 140529 [details] [review] Bug 30952: Change default button style Created attachment 140530 [details] [review] Bug 30952: Change tables style Created attachment 140531 [details] [review] Bug 30952: The rest of CSS changes There is still work to do to split this patch correctly into several more logical patches. Consider this patch a WIP. Created attachment 140532 [details] [review] Bug 30952: (follow-up) Undo change to Home breadcrumb Created attachment 140533 [details] [review] Bug 30952: Undo change to Home breadcrumb for remaining templates Created attachment 140534 [details] [review] Bug 30952: Replace "Home" by icon in breadcrumbs Created attachment 140535 [details] [review] Bug 30952: Fix "rows" forms Issue #7 Created attachment 140536 [details] [review] Bug 30952: Fix position shift when hovering .linktools links Issue #6 Created attachment 140537 [details] [review] Bug 30952: Fix the 'keep_text' feature of the search bar Text in one form should be copied in other forms when switching tab Issue #2 Created attachment 140538 [details] [review] Bug 30952: Show the search catalog form by default in cat-search.inc Issue #1 Created attachment 140539 [details] [review] Bug 30952: Move the toolbar back to the left Issue #8 Created attachment 140540 [details] [review] Bug 30952: Fix alignment of search results Issue #11 Created attachment 140541 [details] [review] Bug 30952: Fix "browse patrons by last name" display Issue #13 Created attachment 140542 [details] [review] Bug 30952: Fix left padding of sidebar Issue #14 Created attachment 140543 [details] [review] Bug 30952: Fix lists display on patron detail page Issue #15 Created attachment 140544 [details] [review] Bug 30952: Fix background color of dialogs (message, alert, error) Issue #9 Created attachment 140545 [details] [review] Bug 30952: Increase contrast between green text and white/grey background Issue #10 Created attachment 140546 [details] [review] Bug 30952: Change color of btn-primary and use that for Check out button Created attachment 140547 [details] [review] Bug 30952: Add "card" layout to the checkout page Also fix the label positioning Created attachment 140548 [details] [review] Bug 30952: Move search bar below navbar and reduce navbar height Created attachment 140549 [details] [review] Bug 30952: Add card layout to patron messages in moremember.pl Created attachment 140550 [details] [review] Bug 30952: Fix background of search header Issue #3 Created attachment 140551 [details] [review] Bug 30952: Fix item edit form Issue #31 Created attachment 140552 [details] [review] Bug 30952: Move 'Clear filter' next to filter in table headers Issue #16 Created attachment 140553 [details] [review] Bug 30952: Change circulation home page links to buttons Apply the same style to staff home page links Issue #18 Created attachment 140554 [details] [review] Bug 30952: Fix table headers Issue #16 Created attachment 140555 [details] [review] Bug 30952: Fix remaining header search bars Created attachment 140556 [details] [review] Bug 30952: Fix background of "Clear filter" button Issue #16 Created attachment 140557 [details] [review] Bug 30952: Fix contrast issue on patron brief view Issue #19 Created attachment 140558 [details] [review] Bug 30952: Remove white text shadow from buttons Issue #20 Created attachment 140559 [details] [review] Bug 30952: Fix pagination colors Issue #21 Created attachment 140560 [details] [review] Bug 30952: Reintroduce table borders Issue #22 Created attachment 140566 [details] [review] Bug 30952: Reintroduce placeholder and classes in catalogue search They were lost in the last rebase Created attachment 140567 [details] [review] Bug 30952: Reintroduce borders in search browse links Issue #23 Created attachment 140570 [details] [review] Bug 30952: Remove messages box on patron detail page when empty Issue #28 Created attachment 140571 [details] [review] Bug 30952: Bring back bullet points for lists Issue #29 Created attachment 140575 [details] [review] Bug 30952: Change sidebar menu headers - Remove the bottom border - Increase font size and weight - Fix a padding issue Created attachment 140576 [details] [review] Bug 30952: Change sidebar menu headers - Remove the bottom border - Increase font size and weight - Fix a padding issue Issue #30 Created attachment 140577 [details] [review] Bug 30952: Fix fieldset legend positioning Issue #27 Created attachment 140588 [details] [review] Bug 30952: Set preferences save buttons as primary buttons Issue #32 Created attachment 140613 [details] [review] Bug 30952: Header search - move tabs to the right (and other tweaks) Make the search bar take the whole page width, with inputs at the center taking all the available space Add a separator between inputs when there are more than one Issue #24 Created attachment 140617 [details] [review] Bug 30952: Fix header search bar for RTL Issue #38 Created attachment 140618 [details] [review] Bug 30952: Fix navbar elements ordering for RTL Issue #38 Created attachment 140619 [details] [review] Bug 30952: Adjust colors of browse search Issue #23 Created attachment 140620 [details] [review] Bug 30952: Fix color of navbar toggle on small screen Issue #37 Created attachment 140628 [details] [review] Bug 30952: Fix toolbar positioning and spacing Created attachment 140629 [details] [review] Bug 30952: Fix style of some buttons Created attachment 140635 [details] [review] Bug 30952: Better header search bar on smaller screens - Show only tab icons on screens <= 992px - Hide form title on the left on screens <= 768px - Move some dropdown lists to the "extra" filters area Issue #24 Created attachment 140649 [details] [review] Bug 30952: Fix spacing of nested fieldsets Issue #42 Created attachment 140650 [details] [review] Bug 30952: Fix positioning of fieldset's elements below a legend Issue #41 Created attachment 140651 [details] [review] Bug 30952: Fix facets block display Issue #40 Created attachment 140652 [details] [review] Bug 30952: Remove useless styles Created attachment 140653 [details] [review] Bug 30952: Add spacing between itemtypes and subtype limits Issue #43 Created attachment 140654 [details] [review] Bug 30952: Stop search bar resizing when switching tab Created attachment 140658 [details] [review] Bug 30952: Fix table styling (cell borders, striping) Issue #22 Created attachment 140687 [details] [review] Bug 30952: (follow-up) Proposed reworking of catalog header menu link Issue #46 Created attachment 140976 [details] [review] Bug 30952: Remove text shadow from buttons so they don't look blurred Created attachment 140977 [details] [review] Bug 30952: Remove text shadow from buttons so they don't look blurred Issue #49 Created attachment 141020 [details] [review] Bug 30952: Add the "card" style to biblio detail page Issue #45 Created attachment 141024 [details] [review] Bug 30952: Harmonize tables style - 2 pixels border below <thead> and above <tfoot> - No border above or below table cells (in thead, tbody and tfoot) - No border around tables Issue #22 Created attachment 141026 [details] [review] Bug 30952: Remove Poppins font, use Bootstrap 5 font stack instead Issue #20 Created attachment 141027 [details] [review] Bug 30952: Fix biblio detail display when covers are enabled Created attachment 141041 [details] [review] Bug 30952: Fix color contrast so we are at least WCAG AA compliant Issue #10 Created attachment 141043 [details] [review] Bug 30952: (follow-up) Use variables for primary and secondary greens _variables.scss currently contains a variable, $background-color-primary, which isn't used. I think we should use that variable anywhere the color is used, and use SASS color calculation to generate the secondary color. The two colors can be compared in the search header: primary for the background, secondary for the submit button color. To test, apply the patch and rebuild the staff interface CSS. Test various pages in the staff interface to confirm that the colors look the same as before: Search header, tab colors, "Last patron" button, etc. Created attachment 141044 [details] [review] Bug 30952: (follow-up) Fix style of floating toolbars This patch makes some changes to floating toolbars, both hc-sticky toolbars and DataTables floating toolbars. The changes fix some bugs in the display (incorrect z-index, unwanted margins) and proposes a different style for .searchheader-style toolbars (e.g. patron search results). To test, apply the patch and rebuild the staff interface CSS. Test pages with various kinds and combinations of floating toolbars, e.g.: - Administration -> System preferences - Patrons -> Patron search results - Administration -> Libraries - Catalog search results Created attachment 141047 [details] [review] Bug 30952: Add label style to label class inside fieldset.rows Issue #51 Created attachment 141052 [details] [review] Bug 30952: Harmonize tabs style - Reduce border width from 3px to 2px - Active tab is white on "primary" green (WCAG AA ✓) - Other tabs are black (#111) on "secondary" green (WCAG AA ✓) - Font weight is normal The patch also removes some useless/redundant CSS properties related to tabs Created attachment 141053 [details] [review] Bug 30952: Change default buttons style to look like .btn.btn-default And do not change the style of these buttons when they are in a table If we want to make them look like links, we should use btn-link class instead Created attachment 141054 [details] [review] Bug 30952: Fix background of header search "extra-content" toggle Created attachment 141055 [details] [review] Bug 30952: Fix toolbar alignment Created attachment 141056 [details] [review] Bug 30952: Fix patroninfo-section alignment Created attachment 141057 [details] [review] Bug 30952: Make the top left logo clickable area wider Issue #35 Created attachment 141064 [details] [review] Bug 30952: Fix style of datatables buttons when not inside a .pager Created attachment 141074 [details] [review] Bug 30952: (follow-up) Avoid nav menu jump between bold and normal I think styling links with a bold hover state results in a "jumpy" look, and I seem to recall making changes in the past to issues like in response to bug reports. I'd like to propose an alternative style for the nav menu which uses color changes to indicate the hover state. This menu can be seen in the sidebar of patron details, bibliographic details, etc. Created attachment 141075 [details] [review] Bug 30952: (follow-up) Restore DataTable sorting icons Some CSS was removed which controlled the appearance of DataTables column sort icons. Without it, DataTables tries to use some default images which do not exist. This patch restores the icons. With it, sorting icons should look like they do in master and there should be no related 404 errors in the console. There is a test instance set up at https://pro-mt38042-koha.demo.biblibre.eu Credentials are "test" / "test" I'll update it as soon as new patches are written so it should always be up-to-date. Please report bugs to https://github.com/jajm/koha-staff-interface-redesign/issues If something prevents you from testing on this instance, please contact me by email or IRC (jajm) I spent some time again today going through the github issues.. lots of great work here.. I would be so bold as to say this is really at the QA stage now.. the general feeling is it's a goer and we're just doing final polishing.. some of which should probably go ahead in their own bugs after this is pushed. I'm going to be bold and say this is Signed Off to get more QA eyes on it. Please have a look at the Z39.50 search - the input fields are misaligned (sorry for posting here... just didn't want to forget) Created attachment 141631 [details] [review] Bug 30952: Staff interface redesign (header) What this patch does: - change the navigation bar style - change the breadcrumbs style - change the "last borrower" link style - move the search bar inside the navigation bar - move the help link to the same row as the breadcrumbs Created attachment 141632 [details] [review] Bug 30952: Add Poppins font assets Created attachment 141633 [details] [review] Bug 30952: Move "Go to advanced/item search" link to toolbar Created attachment 141634 [details] [review] Bug 30952: Staff interface redesign (toolbar) Created attachment 141635 [details] [review] Bug 30952: Change checkout, checkin and renew forms Created attachment 141636 [details] [review] Bug 30952: Staff interface redesign (main page) Created attachment 141637 [details] [review] Bug 30952: Small adjustments in search results page - Move Z39.50 search button to a toolbar - Use btn and btn-link classes for "Select all" and "Clear all" buttons Created attachment 141638 [details] [review] Bug 30952: Change MARC tags toolbar style Created attachment 141639 [details] [review] Bug 30952: Change login page style Created attachment 141640 [details] [review] Bug 30952: Change sysprefs nav menu style Created attachment 141641 [details] [review] Bug 30952: Change default button style Created attachment 141642 [details] [review] Bug 30952: Change tables style Created attachment 141643 [details] [review] Bug 30952: The rest of CSS changes There is still work to do to split this patch correctly into several more logical patches. Consider this patch a WIP. Created attachment 141644 [details] [review] Bug 30952: (follow-up) Undo change to Home breadcrumb Created attachment 141645 [details] [review] Bug 30952: Undo change to Home breadcrumb for remaining templates Created attachment 141646 [details] [review] Bug 30952: Replace "Home" by icon in breadcrumbs Created attachment 141647 [details] [review] Bug 30952: Fix "rows" forms Issue #7 Created attachment 141648 [details] [review] Bug 30952: Fix position shift when hovering .linktools links Issue #6 Created attachment 141649 [details] [review] Bug 30952: Fix the 'keep_text' feature of the search bar Text in one form should be copied in other forms when switching tab Issue #2 Created attachment 141650 [details] [review] Bug 30952: Show the search catalog form by default in cat-search.inc Issue #1 Created attachment 141651 [details] [review] Bug 30952: Move the toolbar back to the left Issue #8 Created attachment 141652 [details] [review] Bug 30952: Fix alignment of search results Issue #11 Created attachment 141653 [details] [review] Bug 30952: Fix "browse patrons by last name" display Issue #13 Created attachment 141654 [details] [review] Bug 30952: Fix left padding of sidebar Issue #14 Created attachment 141655 [details] [review] Bug 30952: Fix lists display on patron detail page Issue #15 Created attachment 141656 [details] [review] Bug 30952: Fix background color of dialogs (message, alert, error) Issue #9 Created attachment 141657 [details] [review] Bug 30952: Increase contrast between green text and white/grey background Issue #10 Created attachment 141658 [details] [review] Bug 30952: Change color of btn-primary and use that for Check out button Created attachment 141659 [details] [review] Bug 30952: Add "card" layout to the checkout page Also fix the label positioning Created attachment 141660 [details] [review] Bug 30952: Move search bar below navbar and reduce navbar height Created attachment 141661 [details] [review] Bug 30952: Add card layout to patron messages in moremember.pl Created attachment 141662 [details] [review] Bug 30952: Fix background of search header Issue #3 Created attachment 141663 [details] [review] Bug 30952: Fix item edit form Issue #31 Created attachment 141664 [details] [review] Bug 30952: Move 'Clear filter' next to filter in table headers Issue #16 Created attachment 141665 [details] [review] Bug 30952: Change circulation home page links to buttons Apply the same style to staff home page links Issue #18 Created attachment 141666 [details] [review] Bug 30952: Fix table headers Issue #16 Created attachment 141667 [details] [review] Bug 30952: Fix remaining header search bars Created attachment 141668 [details] [review] Bug 30952: Fix background of "Clear filter" button Issue #16 Created attachment 141669 [details] [review] Bug 30952: Fix contrast issue on patron brief view Issue #19 Created attachment 141670 [details] [review] Bug 30952: Remove white text shadow from buttons Issue #20 Created attachment 141671 [details] [review] Bug 30952: Fix pagination colors Issue #21 Created attachment 141672 [details] [review] Bug 30952: Reintroduce table borders Issue #22 Created attachment 141673 [details] [review] Bug 30952: Reintroduce placeholder and classes in catalogue search They were lost in the last rebase Created attachment 141674 [details] [review] Bug 30952: Reintroduce borders in search browse links Issue #23 Created attachment 141675 [details] [review] Bug 30952: Remove messages box on patron detail page when empty Issue #28 Created attachment 141676 [details] [review] Bug 30952: Bring back bullet points for lists Issue #29 Created attachment 141677 [details] [review] Bug 30952: Change sidebar menu headers - Remove the bottom border - Increase font size and weight - Fix a padding issue Issue #30 Created attachment 141678 [details] [review] Bug 30952: Fix fieldset legend positioning Issue #27 Created attachment 141679 [details] [review] Bug 30952: Set preferences save buttons as primary buttons Issue #32 Created attachment 141680 [details] [review] Bug 30952: Header search - move tabs to the right (and other tweaks) Make the search bar take the whole page width, with inputs at the center taking all the available space Add a separator between inputs when there are more than one Issue #24 Created attachment 141681 [details] [review] Bug 30952: Fix header search bar for RTL Issue #38 Created attachment 141682 [details] [review] Bug 30952: Fix navbar elements ordering for RTL Issue #38 Created attachment 141683 [details] [review] Bug 30952: Adjust colors of browse search Issue #23 Created attachment 141684 [details] [review] Bug 30952: Fix color of navbar toggle on small screen Issue #37 Created attachment 141685 [details] [review] Bug 30952: Fix toolbar positioning and spacing Created attachment 141686 [details] [review] Bug 30952: Fix style of some buttons Created attachment 141687 [details] [review] Bug 30952: Better header search bar on smaller screens - Show only tab icons on screens <= 992px - Hide form title on the left on screens <= 768px - Move some dropdown lists to the "extra" filters area Issue #24 Created attachment 141688 [details] [review] Bug 30952: Fix spacing of nested fieldsets Issue #42 Created attachment 141689 [details] [review] Bug 30952: Fix positioning of fieldset's elements below a legend Issue #41 Created attachment 141690 [details] [review] Bug 30952: Fix facets block display Issue #40 Created attachment 141691 [details] [review] Bug 30952: Remove useless styles Created attachment 141692 [details] [review] Bug 30952: Add spacing between itemtypes and subtype limits Issue #43 Created attachment 141693 [details] [review] Bug 30952: Stop search bar resizing when switching tab Created attachment 141694 [details] [review] Bug 30952: Fix table styling (cell borders, striping) Issue #22 Created attachment 141695 [details] [review] Bug 30952: (follow-up) Proposed reworking of catalog header menu link Issue #46 Created attachment 141696 [details] [review] Bug 30952: Remove text shadow from buttons so they don't look blurred Issue #49 Created attachment 141697 [details] [review] Bug 30952: Add the "card" style to biblio detail page Issue #45 Created attachment 141698 [details] [review] Bug 30952: Harmonize tables style - 2 pixels border below <thead> and above <tfoot> - No border above or below table cells (in thead, tbody and tfoot) - No border around tables Issue #22 Created attachment 141699 [details] [review] Bug 30952: Remove Poppins font, use Bootstrap 5 font stack instead Issue #20 Created attachment 141700 [details] [review] Bug 30952: Fix biblio detail display when covers are enabled Created attachment 141701 [details] [review] Bug 30952: Fix color contrast so we are at least WCAG AA compliant Issue #10 Created attachment 141702 [details] [review] Bug 30952: (follow-up) Use variables for primary and secondary greens _variables.scss currently contains a variable, $background-color-primary, which isn't used. I think we should use that variable anywhere the color is used, and use SASS color calculation to generate the secondary color. The two colors can be compared in the search header: primary for the background, secondary for the submit button color. To test, apply the patch and rebuild the staff interface CSS. Test various pages in the staff interface to confirm that the colors look the same as before: Search header, tab colors, "Last patron" button, etc. Created attachment 141703 [details] [review] Bug 30952: (follow-up) Fix style of floating toolbars This patch makes some changes to floating toolbars, both hc-sticky toolbars and DataTables floating toolbars. The changes fix some bugs in the display (incorrect z-index, unwanted margins) and proposes a different style for .searchheader-style toolbars (e.g. patron search results). To test, apply the patch and rebuild the staff interface CSS. Test pages with various kinds and combinations of floating toolbars, e.g.: - Administration -> System preferences - Patrons -> Patron search results - Administration -> Libraries - Catalog search results Created attachment 141704 [details] [review] Bug 30952: Add label style to label class inside fieldset.rows Issue #51 Created attachment 141705 [details] [review] Bug 30952: Harmonize tabs style - Reduce border width from 3px to 2px - Active tab is white on "primary" green (WCAG AA ✓) - Other tabs are black (#111) on "secondary" green (WCAG AA ✓) - Font weight is normal The patch also removes some useless/redundant CSS properties related to tabs Created attachment 141706 [details] [review] Bug 30952: Change default buttons style to look like .btn.btn-default And do not change the style of these buttons when they are in a table If we want to make them look like links, we should use btn-link class instead Created attachment 141707 [details] [review] Bug 30952: Fix background of header search "extra-content" toggle Created attachment 141708 [details] [review] Bug 30952: Fix toolbar alignment Created attachment 141709 [details] [review] Bug 30952: Fix patroninfo-section alignment Created attachment 141710 [details] [review] Bug 30952: Make the top left logo clickable area wider Issue #35 Created attachment 141711 [details] [review] Bug 30952: Fix style of datatables buttons when not inside a .pager Created attachment 141712 [details] [review] Bug 30952: (follow-up) Avoid nav menu jump between bold and normal I think styling links with a bold hover state results in a "jumpy" look, and I seem to recall making changes in the past to issues like in response to bug reports. I'd like to propose an alternative style for the nav menu which uses color changes to indicate the hover state. This menu can be seen in the sidebar of patron details, bibliographic details, etc. Created attachment 141713 [details] [review] Bug 30952: (follow-up) Restore DataTable sorting icons Some CSS was removed which controlled the appearance of DataTables column sort icons. Without it, DataTables tries to use some default images which do not exist. This patch restores the icons. With it, sorting icons should look like they do in master and there should be no related 404 errors in the console. All patches rebased on master. As it generates a lot of noises, I might squash all patches before rebasing next time. https://pro-mt38042-koha.demo.biblibre.eu/ is up to date +1 for squashing ! (well done Julian, though) bizarre, in the top menu, english version, it's written "Catalogage" as in french. it used to be "cataloging". Squashing also helps for both rebase and backport, +1 (In reply to Arthur Suzuki from comment #389) > bizarre, in the top menu, english version, it's written "Catalogage" as in > french. > it used to be "cataloging". > Squashing also helps for both rebase and backport, +1 It's part of the IntranetNav syspref, not a translation issue ;) Awesome.. I look forward to jumping on any resulting bugs after push at this point.. lets make it even more polished for the final release.. still plenty of little tweaks in my opinion but getting more eyes on by getting it pushed is my opinion. Arthur.. please don't backport this one ;P.. Pushed to master for 22.11. Nice work everyone, thanks! (In reply to Martin Renvoize from comment #391) > Awesome.. I look forward to jumping on any resulting bugs after push at this > point.. lets make it even more polished for the final release.. still plenty > of little tweaks in my opinion but getting more eyes on by getting it pushed > is my opinion. From now on, separate follow-up bugs here for required tweaks. As usual. > Arthur.. please don't backport this one ;P.. Correct. Arthur, please don't :-D Thanks everyone! (In reply to Tomás Cohen Arazi from comment #392) > Pushed to master for 22.11. That's the first thing I read this morning, and it made my day :) Thanks to all people involved. I'm really glad that it will be in 22.11 ! (In reply to Tomás Cohen Arazi from comment #393) > From now on, separate follow-up bugs here for required tweaks. As usual. Please CC me on follow-up bugs and I'll do my best to fix them - &.cancel { - padding-left: 1em; Why did we remove the padding on the "cancel" links? How do we separate the "submit" button and the "cancel" link now? Created attachment 142604 [details] [review] Bug 30952: Fix selenium/administration_tasks.t Cannot wait more for element '//input[@type="submit"]' to be visible at /kohadevbox/koha/t/lib/Selenium.pm line 189. Created attachment 142605 [details] [review] Bug 30952: Fix selenium/basic_workflow.t Error while executing command: no such element: Unable to locate element: //*[@id="circ_returns_checkin"]/div[2]/div[1]/div[2]/button at /usr/share/perl5/Selenium/Remote/Driver.pm line 411. (In reply to Jonathan Druart from comment #395) > - &.cancel { > - padding-left: 1em; > > Why did we remove the padding on the "cancel" links? How do we separate the > "submit" button and the "cancel" link now? Will be back on bug 32022. It's a big change I'd like to highlight as a new feature with some nice release notes. Help? |